[#3637] - [#33777] Allow overwrite files com_media
- Closed
- 20 Jul 2014
- Medium
- Build: 3.4-dev
- # 3637
- Diff
- zero-24:allow-override-files-com_media
- Foreign ID 33777
User tests: Successful: Unsuccessful:
How to test
- Backend login
- upload a image (com_media)
- upload the same image again (com_media)
- You get an error message "Error: File already exists"
- apply patch
- access the com_media options
- read and understand the tooltip of the option "Allow overwriting files"
- enable the option "Allow overwriting files"
- make sure that you have the permission to delete files (core.delete) for com_media
- try to upload a image (that allready exists) again.
Expected Behavior (after patch)
The old file will delete and the new one is there. (if the user have core.delete for com_media)
Note that if the upload fails in any reasons the file is deleted and can't be restore by Joomla.
Joomla Feature Tracker
Votes
| Labels | |||
| Labels |
Added:
?
|
||
| Title |
|
||||||
Tested and worked fine!
| Title |
|
||||||
I have a problem with this patch:
On Debian 7 + Apache2 + PHP 5.4.4 + Error Reporting to "Development" it seems not to work correctly.
Allow overwriting files: ON -> blank screen.
Allow overwriting files: OFF -> white screen with "Error - File already exists" message on top of screen.
You may blame the J!Tracker Application for transmitting this comment.
Btw could we add a message stating that the file has been overwritten?
The new language strings are not real English. I'm mobile right now but will suggest alternatives later.
Suggested some alternate language strings in better english. However I have left the word override although I suspect a better word is either replace or overwrite
Not sure you'd want this +COM_MEDIA_ERROR_FILE_EXISTS_OVERRIDE= if the user has permissions, file exists and override/overwrite is set to yes. the message should surely be
'file successfully replaced!' ?
thanks @brianteeman i change from override to overwrite and add your strings.
thanks @ChelseaStats You are right. I have change the string.
Well it should be :)
As far as I understood the original plan in the media manager was to not allow overwriting. A hash would prevent it.
Since it's now changed to be without hash in the filename, I don't know the current state. There is probably no logic like in this PR here. So you still can test this and we can merge.
Hi,
I think it'll be possible to add this feature in my implementation as well.
Thanks!
thanks @Buddhima Buddhima@cc89707
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-20 13:53:02 |
Works great, thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3637.
Hi
Just tested the patch. I can't seem to override the files. But I tried to change the if statement on line 95 in administrator/components/com_media/controllers/file.php to == instead of === - That seemed to do the trick