User tests: Successful: Unsuccessful:
For some reason the switches were not displayed in the same way as other similar switches. This leads to confusion (reported elsewhere) and the need for creating additional css.
This Pr resolves that. Made against 4.1 as there are language string removals and additions and I dont know what the policy is for that in j4.
cc @Scrabble96
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_templates Language & Strings |
Labels |
Added:
Language Change
?
|
Category | Administration com_templates Language & Strings | ⇒ | Administration com_templates Language & Strings Repository NPM Change |
Sorry false alarm. Applied to v4.0. OK in v4.1.
Labels |
Added:
NPM Resource Changed
|
I have tested this item
I want to test, but I can't find these switches.
How to do?
I am not in favour of this kind of switches. Switches should be for yes/no only (I know that we have several on other places, and i think it is always wrong).
Why not use a label? like "Hide original file: yes/no?"
I know that we have several on other places, and i think it is always wrong).
so propose a change. this pr is consistent with current usage
What is current usage?
What is current usage?
Verbs shoud be avoided in labels
Probably there is a reason for this rule, and maybe I am wrong with my my personal opinion, that switches should be used only for yes/no and lists for text-alternatives.
If you were German I could help very easily, we can make a noun from every verb :) "Versteckthaltung der Originaldatei"
I will start a discussion for that, because I think it is important. But not directly related to this PR.
I have tested this item
This solution is better than before.
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-06 11:56:36 |
Closed_By | ⇒ | bembelimen | |
Labels |
Added:
?
|
Thx
thanks