? Language Change NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Dec 2021

For some reason the switches were not displayed in the same way as other similar switches. This leads to confusion (reported elsewhere) and the need for creating additional css.

This Pr resolves that. Made against 4.1 as there are language string removals and additions and I dont know what the policy is for that in j4.

Before

image

After

image

cc @Scrabble96

avatar brianteeman brianteeman - open - 21 Dec 2021
avatar brianteeman brianteeman - change - 21 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Dec 2021
Category Administration com_templates Language & Strings
avatar brianteeman brianteeman - change - 21 Dec 2021
Labels Added: Language Change ?
avatar joomla-cms-bot joomla-cms-bot - change - 21 Dec 2021
Category Administration com_templates Language & Strings Administration com_templates Language & Strings Repository NPM Change
avatar Quy
Quy - comment - 21 Dec 2021

PHP Notice: Undefined property: Joomla\Component\Templates\Administrator\View\Template\HtmlView::$mediaFiles in \administrator\components\com_templates\tmpl\template\default.php on line 100

Warning: count(): Parameter must be an array or an object that implements Countable in \administrator\components\com_templates\tmpl\template\default.php on line 100

avatar brianteeman
brianteeman - comment - 21 Dec 2021

@Quy I cannot replicate your error report and there is nothing in this PR remotely related to the line mentioned

avatar Quy
Quy - comment - 21 Dec 2021

Sorry false alarm. Applied to v4.0. OK in v4.1.

avatar brianteeman brianteeman - change - 22 Dec 2021
Labels Added: NPM Resource Changed
avatar Quy Quy - test_item - 22 Dec 2021 - Tested successfully
avatar Quy
Quy - comment - 22 Dec 2021

I have tested this item successfully on b17288b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36366.

avatar sandewt
sandewt - comment - 23 Dec 2021

I want to test, but I can't find these switches. ?
How to do?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36366.

avatar brianteeman
brianteeman - comment - 23 Dec 2021

@sandewt They only display when you are working on a template override. So use the create override functionality and then select one of the newly created overrides and then you will see the switches in the top right

avatar sandewt
sandewt - comment - 23 Dec 2021

With a little trick I can make the buttons visible and get the following. The text is not inline with the buttons. This depends on the screen size.

afbeelding

avatar Quy
Quy - comment - 30 Dec 2021

@sandewt Please run npm i to compile the CSS changes or download/install the prebuilt package.

avatar chmst
chmst - comment - 2 Jan 2022

I am not in favour of this kind of switches. Switches should be for yes/no only (I know that we have several on other places, and i think it is always wrong).

Why not use a label? like "Hide original file: yes/no?"

avatar brianteeman
brianteeman - comment - 2 Jan 2022

I know that we have several on other places, and i think it is always wrong).

so propose a change. this pr is consistent with current usage

avatar chmst
chmst - comment - 2 Jan 2022

What is current usage?

avatar brianteeman
brianteeman - comment - 2 Jan 2022

What is current usage?

Verbs shoud be avoided in labels

avatar chmst
chmst - comment - 2 Jan 2022

Probably there is a reason for this rule, and maybe I am wrong with my my personal opinion, that switches should be used only for yes/no and lists for text-alternatives.

If you were German I could help very easily, we can make a noun from every verb :) "Versteckthaltung der Originaldatei"

I will start a discussion for that, because I think it is important. But not directly related to this PR.

avatar chmst
chmst - comment - 2 Jan 2022

I have tested this item successfully on 9b37b14


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36366.

avatar chmst chmst - test_item - 2 Jan 2022 - Tested successfully
avatar chmst
chmst - comment - 2 Jan 2022

This solution is better than before.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36366.

avatar Quy Quy - alter_testresult - 3 Jan 2022 - Quy: Tested successfully
avatar Quy Quy - change - 3 Jan 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 3 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36366.

avatar bembelimen bembelimen - close - 6 Jan 2022
avatar bembelimen bembelimen - merge - 6 Jan 2022
avatar bembelimen bembelimen - change - 6 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-06 11:56:36
Closed_By bembelimen
Labels Added: ?
avatar bembelimen
bembelimen - comment - 6 Jan 2022

Thx

avatar brianteeman
brianteeman - comment - 6 Jan 2022

thanks

Add a Comment

Login with GitHub to post a comment