? ? Pending

User tests: Successful: Unsuccessful:

avatar frostmakk
frostmakk
20 Dec 2021

Pull Request for Issue # .

Summary of Changes

Patching PHP 8.1 deprecation notices where null is provided instead of 'something'.

Testing Instructions

Code review or checking logs.

Actual result BEFORE applying this Pull Request

Deprecation notices

Expected result AFTER applying this Pull Request

No deprecation notices from these files.

Documentation Changes Required

Probably not.

318edec 20 Dec 2021 avatar frostmakk c1
avatar frostmakk frostmakk - open - 20 Dec 2021
avatar frostmakk frostmakk - change - 20 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Dec 2021
Category Layout Front End Templates (site)
avatar alikon alikon - test_item - 22 Dec 2021 - Tested successfully
avatar alikon
alikon - comment - 22 Dec 2021

I have tested this item successfully on 318edec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36362.

avatar frostmakk frostmakk - change - 22 Dec 2021
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 22 Dec 2021
Category Layout Front End Templates (site) Front End Templates (site)
avatar frostmakk
frostmakk - comment - 22 Dec 2021

@HLeithner Sorry. I put the PunicodeHelper in the library PR instead of here.
Is it the newly merged system tests that make this fail?

avatar frostmakk
frostmakk - comment - 22 Dec 2021

This looks a bit suspicious in the api-test
Undeclared variable?

image

avatar HLeithner
HLeithner - comment - 22 Dec 2021

Can you update tge Branch please

avatar frostmakk
frostmakk - comment - 22 Dec 2021

Sorry. I don't understand.

avatar HLeithner
HLeithner - comment - 22 Dec 2021

merge the current 4.0-dev branch with this pr branch

avatar HLeithner HLeithner - test_item - 23 Dec 2021 - Tested successfully
avatar HLeithner
HLeithner - comment - 23 Dec 2021

I have tested this item successfully on c93dd56


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36362.

avatar HLeithner HLeithner - close - 23 Dec 2021
avatar HLeithner HLeithner - merge - 23 Dec 2021
avatar HLeithner HLeithner - change - 23 Dec 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-23 08:50:16
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 23 Dec 2021

Thanks

Add a Comment

Login with GitHub to post a comment