? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
23 May 2014

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33779&start=0

This gets the categories_default_items JLayout to actually output data

It also adds in a more standardized set of events and implements this into the JViewCategories class

avatar wilsonge wilsonge - open - 23 May 2014
avatar wilsonge wilsonge - change - 24 May 2014
Title
JLayout and Event cleanup of categories views
[#33779] JLayout and Event cleanup of categories views
avatar zero-24
zero-24 - comment - 24 May 2014

@wilsonge
hmm it looks like we have double onContentPrepare on the single weblinks view see (use echo instend of return in the plugin):

duplicate_oncontentprepare

But for me nothing is broken here.

avatar wilsonge
wilsonge - comment - 24 May 2014

Ahh Nice spot @zero-24 it was already in the other JLayout. Can you try again please?

avatar zero-24
zero-24 - comment - 25 May 2014

thanks @wilsonge allo ok now. The issue i noticed above is not realted to this PR it is allreay in staging.

So my tests for this PR pass. Thanks @wilsonge

avatar bnisevic
bnisevic - comment - 31 May 2014

I can not confirm that it works with https://github.com/zero-24/plg_eventstest/blob/master/eventstest.php as described. I don't see any plugin's output in news feeds and contacts, all event outputs from the plugin I can see are showed at following images:
home
joomla bug squash

avatar wilsonge
wilsonge - comment - 31 May 2014

Hi,
This is just for the categories view. i.e. the list of multiple categories. It's not for the single item views of newsfeeds and contacts (etc.). I have a separate patch for contacts and the single category view (see #3630 but that may need some more work)

avatar roland-d
roland-d - comment - 11 Jun 2014

@test successful. Updated JC tracker and set to RTC.

avatar phproberto
phproberto - comment - 23 Jun 2014

@wilsonge is this something you want to change or should I merge it and maybe change my suggestions in the future?

avatar bnisevic
bnisevic - comment - 23 Jun 2014

Merge you with some beer. :)

avatar wilsonge
wilsonge - comment - 23 Jun 2014

The problem is that if we make it a std dev now I'm not sure we can change it before J4 cause of b/c?

I will do it at some point but just so busy at the moment. Up to you if you wanna merge it or not really based on that?

avatar wilsonge
wilsonge - comment - 23 Jun 2014

I do agree it probably should be an array btw

avatar Bakual
Bakual - comment - 29 Jul 2014

@wilsonge You want to change it to use an array? I would prefer arrays as well so it's more consistent with how we have it in other JLayouts.
If you update the PR, can you aslo rebase it and solve the conflicts? Thanks :smile:

avatar infograf768 infograf768 - change - 15 Aug 2014
Labels Removed: ?
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 23 Aug 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 23 Aug 2014
Status New Pending
avatar brianteeman brianteeman - change - 23 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 2 Sep 2014
Category Layout
avatar roland-d
roland-d - comment - 27 Feb 2015

@wilsonge Can you fix this?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3635.
avatar wilsonge
wilsonge - comment - 27 Feb 2015

I can't merge staging into this too much has changed :( I'll come back to it as part of 3.5 when me and @phproberto do the JLayouts work

avatar wilsonge wilsonge - change - 27 Feb 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-02-27 21:45:49
avatar wilsonge wilsonge - close - 27 Feb 2015
avatar wilsonge wilsonge - close - 27 Feb 2015
avatar wilsonge wilsonge - head_ref_deleted - 27 Feb 2015

Add a Comment

Login with GitHub to post a comment