? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
17 Dec 2021

s/atrributes/attributes

avatar PhilETaylor PhilETaylor - open - 17 Dec 2021
avatar PhilETaylor PhilETaylor - change - 17 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Dec 2021
Category Repository NPM Change
avatar brianteeman
brianteeman - comment - 17 Dec 2021

shouldnt bug fixes like this be on the main branch and not the 4.1 branch

avatar PhilETaylor
PhilETaylor - comment - 17 Dec 2021

Considering the task scheduler is a Joomla 4.1 feature and this file doesn't exist in the 4.0-dev branch... no.

avatar richard67
richard67 - comment - 17 Dec 2021

shouldnt bug fixes like this be on the main branch and not the 4.1 branch

@brianteeman The scheduler stuff is only in 4.1, or am I mixing up something?

avatar richard67
richard67 - comment - 17 Dec 2021

But shouldn't the attributes of the es5 and the es6 version be different? => @dgrammatiko Could you have a look on it?

avatar PhilETaylor
PhilETaylor - comment - 17 Dec 2021

But shouldn't the attributes of the es5 and the es6 version be different?

No idea - I just fixed a blatantly obvious typo.

avatar richard67
richard67 - comment - 17 Dec 2021

Yes, and the typo fix is right of course.

avatar richard67 richard67 - test_item - 17 Dec 2021 - Tested successfully
avatar richard67
richard67 - comment - 17 Dec 2021

I have tested this item successfully on d4ca03d

Typo fix is right. Other stuff (values of the attributes) need to be checked separately.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36342.

avatar dgrammatiko
dgrammatiko - comment - 17 Dec 2021

But shouldn't the attributes of the es5 and the es6 version be different

Yes, the current definition is wrong, here's the correct one:

    {
      "name": "plg_system_schedulerunner.run-schedule.es5",
      "type": "script",
      "uri": "plg_system_schedulerunner/run-schedule-es5.min.js",
      "dependencies": [
        "core"
      ],
      "attributes": {
        "nomodule": true,
        "defer": true
      }
    },
    {
      "name": "plg_system_schedulerunner.run-schedule",
      "type": "script",
      "uri": "plg_system_schedulerunner/run-schedule.min.js",
      "dependencies": [
         "plg_system_schedulerunner.run-schedule.es5"
       ],
       "attributes": {
         "type": "module"
       }
avatar PhilETaylor PhilETaylor - change - 17 Dec 2021
Labels Added: NPM Resource Changed ?
avatar PhilETaylor
PhilETaylor - comment - 17 Dec 2021

added "type": "module"

avatar richard67 richard67 - test_item - 17 Dec 2021 - Tested successfully
avatar richard67
richard67 - comment - 17 Dec 2021

I have tested this item successfully on dcad600

By review. Typo fixed and values corrected. Now the es6 is loaded as module and the es5 not, like it should be.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36342.

avatar dgrammatiko dgrammatiko - test_item - 17 Dec 2021 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 17 Dec 2021

I have tested this item successfully on dcad600


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36342.

avatar richard67 richard67 - change - 17 Dec 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 17 Dec 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36342.

avatar bembelimen bembelimen - change - 18 Dec 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-18 14:04:02
Closed_By bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 18 Dec 2021
avatar bembelimen bembelimen - merge - 18 Dec 2021
avatar bembelimen
bembelimen - comment - 18 Dec 2021

Thx

Add a Comment

Login with GitHub to post a comment