User tests: Successful: Unsuccessful:
s/atrributes/attributes
Status | New | ⇒ | Pending |
Category | ⇒ | Repository NPM Change |
Considering the task scheduler is a Joomla 4.1 feature and this file doesn't exist in the 4.0-dev branch... no.
shouldnt bug fixes like this be on the main branch and not the 4.1 branch
@brianteeman The scheduler stuff is only in 4.1, or am I mixing up something?
But shouldn't the attributes of the es5 and the es6 version be different? => @dgrammatiko Could you have a look on it?
But shouldn't the attributes of the es5 and the es6 version be different?
No idea - I just fixed a blatantly obvious typo.
Yes, and the typo fix is right of course.
I have tested this item
Typo fix is right. Other stuff (values of the attributes) need to be checked separately.
But shouldn't the attributes of the es5 and the es6 version be different
Yes, the current definition is wrong, here's the correct one:
{
"name": "plg_system_schedulerunner.run-schedule.es5",
"type": "script",
"uri": "plg_system_schedulerunner/run-schedule-es5.min.js",
"dependencies": [
"core"
],
"attributes": {
"nomodule": true,
"defer": true
}
},
{
"name": "plg_system_schedulerunner.run-schedule",
"type": "script",
"uri": "plg_system_schedulerunner/run-schedule.min.js",
"dependencies": [
"plg_system_schedulerunner.run-schedule.es5"
],
"attributes": {
"type": "module"
}
Labels |
Added:
NPM Resource Changed
?
|
added "type": "module"
I have tested this item
By review. Typo fixed and values corrected. Now the es6 is loaded as module and the es5 not, like it should be.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-18 14:04:02 |
Closed_By | ⇒ | bembelimen | |
Labels |
Added:
?
|
Thx
shouldnt bug fixes like this be on the main branch and not the 4.1 branch