[#36324] - [3.10] Fix Progressive caching to cache modules per custom menu assignment
- Fixed in Code Base
- 8 Jan 2022
- Medium
- Build: 3.10-dev
- # 36324
- Diff
- Fedik:cache-fix-310
User tests: Successful: Unsuccessful:
Pull Request for Issue #36102 and #36317 and #36323 .
Summary of Changes
Same as #36193 for J 4.
Progressive caching caches the modules per position, however this breaks custom menu assignment for module.
I have add Itemid to cache key for Progressive caching, so it works correctly now.
upd: it was broken by #35528
Testing Instructions
Apply patch and please follow linked issue: #36102 and #36317 and #36323
Create a custom module, and assign to one specific menu.
Enable Progressive caching, and visit that menu, then visit other pages.
Actual result BEFORE applying this Pull Request
The module visible on all pages.
Expected result AFTER applying this Pull Request
The module visible only on selected page.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
I've restored the previous human test result in the issue tracker since the commit which invalidated the test was just the change from get_class(...) to \get_class(...), which doesn't change anything related to the test and it fine for me by review.
Adding a release blocker label here
| Labels |
Added:
Release Blocker
|
||
I'm sorry for messing arround here again but I have hopefully improved the the codestyle now and moved the cast to integer out of the md5 call.
Will merge it for now thanks guys :)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-08 18:33:03 |
| Closed_By | ⇒ | zero-24 |
I have tested this item✅ successfully on 60d445c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36324.