? Success

User tests: Successful: Unsuccessful:

avatar perspektiveweb
perspektiveweb
22 May 2014

Issue

When running Joomla on my local host or any other php environment that has the maximum or development error reporting enabled, the ajax request that the control panel received to determine whether there are updates available or not contains a php parser notice that prevents the JSON response to be interpreted correctly.

Solution

The error happens in Line 97 of the libraries/joomla/adapters/extension.php. It needs to be checked whether $this->currentUpdate is null before checking it's values in the if statement.

avatar perspektiveweb perspektiveweb - open - 22 May 2014
avatar Bakual
Bakual - comment - 22 May 2014

I've updated and renamed this PR with the information from the original Issue.
Can you maybe open a tracker on our JoomlaCode Issue tracker? (http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103)

avatar perspektiveweb
perspektiveweb - comment - 22 May 2014

Thanks Bakual! Sorry about that double posting there, I wasn't familiar with the process yet. I'm happy to create a joomlaCode tracker item.

avatar perspektiveweb
perspektiveweb - comment - 22 May 2014

I created the item. Do I have to connect it to this issue other than by adding the URL of this PULL request?
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33771&start=0

avatar wilsonge
wilsonge - comment - 22 May 2014

No that's fine :) The links perfect thank you

avatar perspektiveweb
perspektiveweb - comment - 23 May 2014

Oh that's correct! Odd it still resolved the error for me. I will switch the position and make another PR

avatar Fedik
Fedik - comment - 23 May 2014

no need another PR,
enough just another commit :wink:

avatar perspektiveweb
perspektiveweb - comment - 23 May 2014

Thanks got it!

On 22/05/2014 18:19, George Wilson wrote:

No that's fine :) The links perfect thank you


Reply to this email directly or view it on GitHub
#3632 (comment).


This email is free from viruses and malware because avast! Antivirus protection is active.
http://www.avast.com

avatar perspektiveweb
perspektiveweb - comment - 26 May 2014

Done!

avatar bnisevic
bnisevic - comment - 31 May 2014

Tested with "Maximum" and "Development". Works. Good for merge.

avatar Bakual
Bakual - comment - 31 May 2014

One more tester please :smile:

avatar perspektiveweb
perspektiveweb - comment - 2 Jun 2014

Can I test my own code?

avatar wilsonge
wilsonge - comment - 2 Jun 2014

sadly not. I'll try and test it tonight if i can fix my computer so I can use my localhost :P

avatar Bakual
Bakual - comment - 2 Jun 2014

Can I test my own code?

We actually hope you already tested your code before you submitted it :smile:

avatar wilsonge
wilsonge - comment - 2 Jun 2014

Can I test my own code?

We actually hope you already tested your code before you submitted it :smile:

hides

avatar perspektiveweb
perspektiveweb - comment - 2 Jun 2014

Haha yes, I did, true

Sent from my iPhone

On Jun 2, 2014, at 3:33 PM, Thomas Hunziker notifications@github.com wrote:

Can I test my own code?

We actually hope you already tested your code before you submitted it


Reply to this email directly or view it on GitHub.

avatar roland-d
roland-d - comment - 8 Jun 2014

@perspektiveweb
Cross-post from JoomlaCode:
I can't replicate the issue either. Since this is reported for Joomla 3.1.5, can you confirm the issue still exists in Joomla 3.3?

avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman
brianteeman - comment - 22 Aug 2014

Thank you for your contribution and participation in the bug tracking process. As there has been no response to the request for further information I am closing this report at this time.

We have now moved our bug tracking process to http://issues.joomla.org/ so if you have further information that would enable this issue to be reopened please update the issue at http://issues.joomla.org/tracker/joomla-cms/3632 and it can be reopened.

avatar brianteeman brianteeman - change - 22 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-22 10:29:35
avatar brianteeman brianteeman - close - 22 Aug 2014

Add a Comment

Login with GitHub to post a comment