[#36315] - [4.0] Ensure path contains api in the router
- Fixed in Code Base
- 4 Jan 2022
- Medium
- Build: 4.0-dev
- # 36315
- Diff
- Digital-Peak:j4/api/live/site
User tests: Successful: Unsuccessful:
Summary of Changes
When the live_site attribute is set in the Joomla configuration.php file, then all API requests do fail with a 404 "Resource not found" error.
Testing Instructions
Lets assume the website runs on http://joomla.box/cms4 (in your case use your own url).
- Set the live site parameter in the configuration.php file to http://joomla.box/cms4
- Make a get request with the bearer token to the following url http://joomla.box/cms4/api/index.php/v1/content/articles
Actual result BEFORE applying this Pull Request
404 error
Expected result AFTER applying this Pull Request
List of articles with a 200 return code
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36315.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36315.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36315.
Isn't it a better/more consistent fix to add the same thing we have for the administrator app https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Uri/Uri.php#L151-L157 for the api app?
I never liked the dependency of Uri to to an app. But if you want me to add there another if block, then I can do it. All I want is to make the api actually work with the live site parameter.
I'm not against moving things around (but if I was doing that I'd probably be using the application to seed the base url/path into Uri rather than having them duplicating them determining URLs). But I think that would be for a minor version. For a patch version consistency is probably the best course of action.
| Labels |
Added:
?
?
|
||
Fine by me. Can you update your base branch please so that the API tests run through just as a sanity check.
The failing tests have nothing to do with the pr as they are date related.
Yeah before the API tests weren't starting because it was behind (and Harald's been doing drone system test work). Obviously fine now!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-04 11:45:45 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on 743cbe6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36315.