[#36312] - [3.10] Dont show the pre upgrade checker when the upgrade is not supported
- Fixed in Code Base
- 8 Jan 2022
- Medium
- Build: 3.10-dev
- # 36312
- Diff
- zero-24:non-supported
User tests: Successful: Unsuccessful:
Summary of Changes
Dont show the pre upgrade checker when the upgrade is not supported
Testing Instructions
- install 3.10 on a non supported setup for J4 that is checked by the updater lib (ex. mysql version older than 5.6)
- switch the update server to Joomla Next
- you see a pre upgrade checker
- apply this patch
- The pre upgrade checker is gone
Tip
when you dont have a setup with such an old mysql version you can fake it by adding $dbMatch = false; after this line here: https://github.com/joomla/joomla-cms/blob/3.10-dev/libraries/src/Updater/Update.php#L403
Actual result BEFORE applying this Pull Request
You see a pre upgrade checker with false information as the update is not fully aviable nor working at all.
Expected result AFTER applying this Pull Request
The pre upgrade checker is gone
Documentation Changes Required
none
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
I have tested this item
This is obviously incorrect. None of the three explanations are anything to do with the title "We can't find a download url"
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36312.
Yes I have not changed the language string but I'm happy to do so. What would be a better fit as title?
Update unavailable
?
| Labels |
Added:
?
|
||
| Category | Administration com_joomlaupdate | ⇒ | Administration com_joomlaupdate Language & Strings |
Done thanks :)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36312.
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36312.
Thats better but I wonder why you are not displaying the results of the required settings tests. That way someone will know that the reason an update is not available is specifically due to their server not meeting the minimum requirements and specifically which ones. Better to help them with the upgrade instead of keeping it a secret
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36312.
In this specific case its not something thats checked at the pre upgrade checker level but in the updater class and can have different reasons other than a wrong not supported server setup. :(
For now the aim here is to hide the clearly wrong information shown for such sites.
In which case I don't see this as an improvement but a quick fix that doesnt address the issue of informing the user why they cannot upgrade
| Labels |
Added:
Language Change
|
||
I agree with @brianteeman however fixing that is going to be something super deep and super low level (because of the internals of how the update class works). and in the mean time users are getting confused because they see the wrong PHP/DB info in the pre-update checker. We need to aim to put it back. But until we have the right info showing I think we should probably hide it unfortunately :(
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-08 18:27:20 |
| Closed_By | ⇒ | wilsonge |
kept for future use ;)
I have tested this item✅ successfully on 49633ff
Thanks @zero-24 for this improvement
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36312.