User tests: Successful: Unsuccessful:
Don't convert domain to punycode if domain is already a Punycode string
Pull Request for Issue #36301 .
In Global Configuration, Server tab, in mail section, update "from email" parameter so that domain name contains one or more accented character. Click on "Send TestMail".
Nothing happens : no error, no email sent
a message "The email was sent to ..." is displayed and, if domain exists, you should receive an email.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Title |
|
Labels |
Added:
?
|
Maybe
if (preg_match('/[^\x20-\x7e]/', $utfString))
this is the type of thing that is best tested with Unit Tests - can you provide a set of Unit tests as well?
the regex will always match because it doesn't except . right?
and it would be easier to test for xn--
and it would be easier to test for
xn--
I was not sure about uniqueness of the prefix.
Updated code to ignore AlreadyPunycodeException instead of testing domain value.
The PR works fine for me: test email sent and well received, no more Punycode error.
Thanks!
@conseilgouz : Any idea when this PR will be merged. So the fix would be available for consumers :-)
Thanks for an update.
@conseilgouz : Any idea when this PR will be merged. So the fix would be available for consumers :-) Thanks for an update.
This PR has been marked "closed", and is not in 4.1.
No idea who did that, but, I think that as nobody tested it, it's normal PR life.....
@conseilgouz : Thanks for your quick reply.
At the moment I can confirm that the issue is still reproducible in 4.1.4
So how to proceed? What do you suggest?
Above I saw: [1]. So the PR was tested
[1]
fontanil commented on Dec 16, 2021
The PR works fine for me: test email sent and well received, no more Punycode error.
Thanks!
@conseilgouz : Thanks for your quick reply.
At the moment I can confirm that the issue is still reproducible in 4.1.4
So how to proceed? What do you suggest?
Above I saw: [1]. So the PR was tested
[1]
fontanil commented on Dec 16, 2021 The PR works fine for me: test email sent and well received, no more Punycode error. Thanks!
A PR has to be "human tested" twice, following the right procedure.
fontanil commented on Dec 16, 2021 just said it was ok, but did not respect the procedure, so no human test has be recorded for this PR => dead PR
To go RTC, it has to be reopened and tested.
@conseilgouz : Thanks for your update. Are you going to reopen the PR? If not: Who can do this?
Labels |
Added:
?
Removed: ? |
pr opened as rquested #36301 (comment)
@FrankReisenhofer @fontanil : please test this PR and send your result via https://issues.joomla.org/tracker/joomla-cms/36303
I have tested this item
With the fix the reported issue is no longer occurring. My human manual tests are green
I have tested this item
Tested after manual changes in the file (Patch tester doesn't change the code) : no more error for me.
RTC
Status | Pending | ⇒ | Ready to Commit |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-05 19:05:17 |
Closed_By | ⇒ | bembelimen | |
Labels |
Added:
?
|
Thx
Tested with
infograf@avélaccent.fr
Before patch, we get the error
An error has occurred while fetching the JSON data: HTTP 0 status code.
After patch, the mail is sent.
Still remains a problem:
After patch: I can't save such an email as I get a warning
The email address you entered is invalid. Please enter another email address.
I guess the regex may be wrong