[#36297] - [4.1] Unification of the language com_scheduler, part 3
- Fixed in Code Base
- 31 Dec 2021
- Medium
- Build: 4.1-dev
- # 36297
- Diff
- tecpromotion:unification-wording-com-scheduler-part-3
User tests: Successful: Unsuccessful:
Summary of Changes
During the translation into German and testing, an error occurred in the display of the duration time.
This PR shows the correct output.
Testing Instructions
create a new taks an click Run Test.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
ouch - I made that change and none of the testers spotted it
yes, unfortunately i didn't test that enough with my team when beta1 was released. but we should test it thoroughly again before the stable release.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.
@tecpromotion Please use %f instead.
| Status | Ready to Commit | ⇒ | Pending |
@tecpromotion Could you have a look on the review suggestions and check if "%f" works, and if so, change to that? I'd like to come forward here, but I'm a bit reluctant to set RTC as long as there are open review discussions.
@tecpromotion Could you have a look on the review suggestions and check if "%f" works, and if so, change to that? I'd like to come forward here, but I'm a bit reluctant to set RTC as long as there are open review discussions.
I can check this later.
@tecpromotion Please use
%finstead.
@wojsmol Sorry but '%f' does not work here.
Here a '%s' is searched for and replaced.
Change both to %f does not work.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36297.
| Labels |
Added:
?
|
||
| Labels |
Added:
Language Change
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-31 12:55:32 |
| Closed_By | ⇒ | bembelimen |
Thx
merged ? !!!!
why ?
evidently feedback from some are not welcomed or better simply ignored
@alikon Why ignored? @tecpromotion has checked with "%s" as requested and has reported back why we can't do that with the js as it is now.
this doesn't prove it's correct
this doesn't prove it's correct
You're absolutely right, but that doesn't solve the problem.
A developer has to sit down and fix it everywhere.
Now there is an output and no more error.
ouch - I made that change and none of the testers spotted it