Joomla! Issue Tracker | Joomla! CMS #36257 - [4.x] Template preview broken

No Code Attached Yet

Closed
8 Dec 2021
Medium
Build: 4.0-dev
# 36257

brianteeman
7 Dec 2021

Steps to reproduce the issue

With no modules and template preview enabled all module positions should be indicated. They're not and this makes the preview completely pointless

Expected result

Actual result

Additional comments

The problem appears to originate with #35225 by @Fedik

Possibly here https://github.com/joomla/joomla-cms/pull/35225/files#r693565865

brianteeman - open - 7 Dec 2021

joomla-cms-bot - change - 7 Dec 2021

Labels

Added: No Code Attached Yet

joomla-cms-bot - labeled - 7 Dec 2021

chmst - comment - 7 Dec 2021

Duplicate to #36071?

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36257.}

Fedik - comment - 8 Dec 2021

#35225 that just fixing a cache,

The issue a bit different, since #19416 some positions rendered only if they contain any real content,
So in result you see preview only for these positions.

Possible fix, is to update if() statement a bit, example

joomla-cms/templates/cassiopeia/index.php

Lines 187 to 191 in 913f8e7

    
           <?php if ($this->countModules('banner', true)) : ?> 
        
           	<div class="container-banner full-width"> 
        
           		<jdoc:include type="modules" name="banner" style="none" /> 
        
           	</div> 
        
           <?php endif; ?>

Change to something like:

if ($templatePreview || $this->countModules('banner', true))

Duplicate to #36071?

Yes, it the same.

brianteeman - comment - 8 Dec 2021

#35225 that just fixing a cache,

Well the problem didnt exist before and it does after

Possible fix, is to update if() statement a bit, example

That "fix" is specific to cassiopeia so it doesnt solve the problem.

The issue a bit different, since #19416 some positions rendered only if they contain any real content,

Ok thanks for the hint I will take a look there as this issue really bugs me

Fedik - comment - 8 Dec 2021

That "fix" is specific to cassiopeia so it doesnt solve the problem.

That fix is specific for templates that use this new feature.

I wonder if old behavior still show all positions if the position does not have any module assigned in backend?
if ($this->countModules('banner'))

Fedik - comment - 8 Dec 2021

I wonder if old behavior still show all positions if the position does not have any module assigned in backend?

Yea, it is, it have this horror hack ?

joomla-cms/libraries/src/Helper/ModuleHelper.php

Lines 101 to 111 in 7978f28

    
           if (\count($result) === 0) 
        
           { 
        
           	if ($input->getBool('tp') && ComponentHelper::getParams('com_templates')->get('template_positions_display')) 
        
           	{ 
        
           		$result[0] = static::createDummyModule(); 
        
           		$result[0]->title = $position; 
        
           		$result[0]->position = $position; 
        
           	} 
        
           }

So it force empty module, if position is empty but &tp=1 exists
hmhm

Fedik - comment - 8 Dec 2021

Well, we can extend that hack,
Can someone try to add next code and check if it works:

$result[0]->contentRendered = true;
$result[0]->content = 'Dummy module';

hm no

Fedik - comment - 8 Dec 2021

Please test #36268

Fedik - change - 8 Dec 2021

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2021-12-08 16:45:30
Closed_By		⇒	Fedik

Fedik - close - 8 Dec 2021

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#36257] - [4.x] Template preview broken

Steps to reproduce the issue

Expected result

Actual result

Additional comments

Add a Comment

	<?php if ($this->countModules('banner', true)) : ?>
	<div class="container-banner full-width">
	<jdoc:include type="modules" name="banner" style="none" />
	</div>
	<?php endif; ?>


	if (\count($result) === 0)
	{
	if ($input->getBool('tp') && ComponentHelper::getParams('com_templates')->get('template_positions_display'))
	{
	$result[0] = static::createDummyModule();
	$result[0]->title = $position;
	$result[0]->position = $position;
	}
	}