Feeling Lucky
?
?
[#36253] - [4.1] Refactor tinyMCE code
- Fixed in Code Base
- 6 Jan 2022
- Medium
- Build: 4.1-dev
- # 36253
- Diff
- dgrammatiko:4.1-dev-tinyMCE-refactor
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- commit 42b1cb4 is a general cleanup (short arrays, elvis operator and move the js script invocation to the layout)
- commit af03018 is breaking up the code using traits
This code should be a tiny faster for front end views that don't have a tinyMCE instance
Testing Instructions
Check that tinymce is working as expected (front end back end)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No.
@Fedik can you review this one?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Front End Plugins |
| Labels |
Added:
?
|
||
laoneo
- comment
- 6 Jan 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36253.
Fedik
- comment
- 6 Jan 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36253.
| Status | Pending | ⇒ | Ready to Commit |
Fedik
- comment
- 6 Jan 2022
R2C
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36253.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-06 11:57:15 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
bembelimen
- comment
- 6 Jan 2022
Thx
Looks good.
I do not see a big reason to use traits, but if it works then I am fine with that :)