? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
6 Dec 2021

If a task has a note then it is displayed below the task name inside a small span (just like in all other components)

If a task does not have a note then a small span is still present but it contains a language string (which is empty)

There is no need for this empty span and there is certainly no need for a language string with no content.

To test

Create a new task with a note
Create another new task without a note
Check the source code and you will see the empty span on the second task

Apply this PR
Refresh and check the source of the page again. This time there is no empty span on the task without a note and the note is still displayed on the other task.

avatar brianteeman brianteeman - open - 6 Dec 2021
avatar brianteeman brianteeman - change - 6 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Dec 2021
Category Administration Language & Strings
avatar brianteeman brianteeman - change - 6 Dec 2021
Labels Added: Language Change ?
avatar Quy
Quy - comment - 6 Dec 2021

I have tested this item successfully on 0ce9a11


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36244.

avatar Quy Quy - test_item - 6 Dec 2021 - Tested successfully
avatar richard67
richard67 - comment - 6 Dec 2021

@brianteeman Couldn't the "COM_SCHEDULER_NO_NOTE" string be removed from the language file? As far as I can see it is not used anymore after the change here.

avatar brianteeman
brianteeman - comment - 6 Dec 2021

@richard67 it is removed

avatar richard67
richard67 - comment - 6 Dec 2021

Oh, how could I miss that.

avatar alikon alikon - test_item - 8 Dec 2021 - Tested successfully
avatar alikon
alikon - comment - 8 Dec 2021

I have tested this item successfully on d807091


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36244.

avatar alikon alikon - alter_testresult - 8 Dec 2021 - Quy: Tested successfully
avatar alikon alikon - change - 8 Dec 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 8 Dec 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36244.

avatar bembelimen bembelimen - change - 13 Dec 2021
Labels Added: ?
avatar bembelimen bembelimen - change - 13 Dec 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-13 07:54:51
Closed_By bembelimen
avatar bembelimen bembelimen - close - 13 Dec 2021
avatar bembelimen bembelimen - merge - 13 Dec 2021
avatar bembelimen
bembelimen - comment - 13 Dec 2021

Thx

avatar brianteeman
brianteeman - comment - 13 Dec 2021

thx

Add a Comment

Login with GitHub to post a comment