? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
6 Dec 2021

The Directory to check is a required field. But because of the options in the xml it will happily store "None Selected" which is an error and so the required attribute does nothing.

This PR corrects that behaviour

To test
Create a new scheduled task for Image Size check. You can save the task with directory set as None Selected
After the pr you will now get an error if you try to save with None Selected

After

image

avatar brianteeman brianteeman - open - 6 Dec 2021
avatar brianteeman brianteeman - change - 6 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Dec 2021
Category Front End Plugins
avatar Quy Quy - test_item - 6 Dec 2021 - Tested successfully
avatar Quy
Quy - comment - 6 Dec 2021

I have tested this item successfully on 139eb9e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36240.

avatar brianteeman brianteeman - change - 7 Dec 2021
Labels Added: ?
avatar alikon alikon - test_item - 8 Dec 2021 - Tested successfully
avatar alikon
alikon - comment - 8 Dec 2021

I have tested this item successfully on be407f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36240.

avatar alikon alikon - alter_testresult - 8 Dec 2021 - Quy: Tested successfully
avatar alikon alikon - change - 8 Dec 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 8 Dec 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36240.

avatar khu5h1 khu5h1 - test_item - 14 Dec 2021 - Tested successfully
avatar khu5h1
khu5h1 - comment - 14 Dec 2021

I have tested this item successfully on be407f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36240.

avatar bembelimen bembelimen - close - 18 Dec 2021
avatar bembelimen bembelimen - merge - 18 Dec 2021
avatar bembelimen bembelimen - change - 18 Dec 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-12-18 14:11:41
Closed_By bembelimen
Labels Added: ?
avatar bembelimen
bembelimen - comment - 18 Dec 2021

Thx

Add a Comment

Login with GitHub to post a comment