? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
6 Dec 2021

Updates the plugin to use the new image data used in lazy loading etc. This avoids confusion for users who see different source code for their created articles when compared to the same data plugins. Seen questions about this several times on the forum

To test. Just make sure the sample data still installs and works as expected

avatar brianteeman brianteeman - open - 6 Dec 2021
avatar brianteeman brianteeman - change - 6 Dec 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Dec 2021
Category Front End Plugins
avatar richard67
richard67 - comment - 6 Dec 2021

@brianteeman The PHP CS check complains about too long lines.

e135e68 6 Dec 2021 avatar brianteeman cs
avatar brianteeman brianteeman - change - 6 Dec 2021
Labels Added: ?
avatar chmst chmst - test_item - 6 Dec 2021 - Tested successfully
avatar chmst
chmst - comment - 6 Dec 2021

I have tested this item successfully on e135e68

Testing instruction for new contributors:

If you have a Joomla installation and if there are installed the blog sample data:
Go thourgh the site and see where are images.

Then make a fresh installation (you can enforce that by deleting the configuration.php and the database via phpmyadmin).
Apply the Patch.
Install Blog Sample Data.
Now check the frontend if they are as in the old installation


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36237.
avatar ChristineWk ChristineWk - test_item - 6 Dec 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 6 Dec 2021

I have tested this item successfully on e135e68


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36237.

avatar ChristineWk
ChristineWk - comment - 6 Dec 2021

result - fresh installation

screen shot 2021-12-06 at 21 29 32


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36237.

avatar ChristineWk
ChristineWk - comment - 6 Dec 2021

result - fresh installation

screen shot 2021-12-06 at 21 29 32


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36237.

avatar richard67 richard67 - change - 6 Dec 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 6 Dec 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36237.

avatar richard67
richard67 - comment - 6 Dec 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36237.

avatar khu5h1 khu5h1 - test_item - 14 Dec 2021 - Tested successfully
avatar khu5h1
khu5h1 - comment - 14 Dec 2021

I have tested this item successfully on e135e68


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36237.

avatar brianteeman
brianteeman - comment - 14 Dec 2021

@khu5h1 there is no way that you have tested this in the minute since your last test result. It is a physical impossibility

avatar wilsonge wilsonge - change - 4 Jan 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-04 17:00:53
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 4 Jan 2022
avatar wilsonge wilsonge - merge - 4 Jan 2022
avatar wilsonge
wilsonge - comment - 4 Jan 2022

Luckily we have two other good tests as well so merging. Thanks!

Add a Comment

Login with GitHub to post a comment