[#36231] - [4.1] Add server timing response header in debug mode
- Fixed in Code Base
- 25 Jan 2022
- Medium
- Build: 4.1-dev
- # 36231
- Diff
- Digital-Peak:j4/server/timing
User tests: Successful: Unsuccessful:
Summary of Changes
Browsers do support a server timing header field which adds information what happens on the server side. This basically gives the developer insight what happens in the "Time to First Byte".
This pr adds the missing header in the debug plugin, as this header should not be added when in production mode because of performance reasons.
Would be nice to get some feedback about spicing up the values of the header as currently I'm just logging them as they are.
The view looks like in the following picture:
Testing Instructions
- When testing in Firefox, make sure you open the page with HTTPS
- Put joomla in debug mode
- In the debug plugin with make sure that the Profile collector is enabled (is by default)
- Open any page
- Open the dev tools and check the Network tab
- Select the first entry and then click on the timings tab of the specific request
Actual result BEFORE applying this Pull Request
Only the request timing information is shown.
Expected result AFTER applying this Pull Request
Beside the request timing is the server timing information shown.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Front End Plugins |
| Labels |
Added:
?
|
||
Maybe add a colon after each description for consistency.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36231.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36231.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-25 03:46:01 |
| Closed_By | ⇒ | bembelimen |
Thx
I have tested this item✅ successfully on cf42d70
@bembelimen this would be great Dev DX if could land in 4.1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36231.