[#36225] - [4.1] Fix broken aria label
- Fixed in Code Base
- 7 Dec 2021
- Medium
- Build: 4.1-dev
- # 36225
- Diff
- bembelimen:4.1/fix-aria-label
User tests: Successful: Unsuccessful:
Pull Request for Issue #36215 .
Summary of Changes
Fix the wrong aria attribute for the search field in the filter section.
Testing Instructions
Go to any search toolbar in the backend and inspect the search field.
Actual result BEFORE applying this Pull Request
aria-describedby IS NOT the same as the ID of the description field.
Expected result AFTER applying this Pull Request
aria-describedby IS the same as the ID of the description field.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change Layout |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36225.
| Labels |
Added:
Release Blocker
a11y
NPM Resource Changed
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36225.
@bembelimen I'd set RTC because it has 2 tests, but if possible could you answer @laoneo 's review comment above? Thanks in advance.
Ah I see Brian's test was before the last 2 commits, so no RTC yet.
@brianteeman Could you test again? Thanks in advance.
Why a new issue, better to fix it from the beginning right?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36225.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36225.
@bembelimen I've set RTC because it has 2 good tests, but maybe you want to check @laoneo 's latest comment.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-07 14:52:35 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Setting release blocker label as inherited from the issue.