? Success

User tests: Successful: Unsuccessful:

avatar AlexRed
AlexRed
20 May 2014

If you publish a Module Articles Category and in Grouping Options > parameter Article Grouping you select an option, for exemple "Year", you will see in frontend that the year is not shown.

This pull request solves the issue

JoomlaCode Tracker Item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33762&start=0

avatar AlexRed AlexRed - open - 20 May 2014
avatar losedk
losedk - comment - 21 May 2014

Tested. The group name is shown now, but I think $item_heading should be removed, since it has no effect and there's no possibility to declare it.

avatar AlexRed
AlexRed - comment - 21 May 2014

yes, but not remover $item_heading :(
set in default.php
<<?php echo $item_heading; ?>><?php echo $group_name; ?></<?php echo $item_heading; ?>>
and in modules/mod_articles_category/mod_articles_category.php
line 72 from
$item_heading = $params->get('item_heading');
to
$item_heading = $params->get('header_tag');

and now you can use the advanced parameter "Header Tag" in the module admin

avatar losedk
losedk - comment - 21 May 2014

I think a solution like the one in mod_article_news is better. Then you can use $item_heading.

avatar AlexRed
AlexRed - comment - 21 May 2014

I'm sorry but I don't know the solution in mod_article_news. But if it is better is ok :)

avatar losedk
losedk - comment - 21 May 2014

Okay :)

It's possible to specify the item_heading:

<field
name="item_heading"
type="list"
default="h4"
label="MOD_ARTICLES_NEWS_TITLE_HEADING"
description="MOD_ARTICLES_NEWS_TITLE_HEADING_DESCRIPTION">
<option value="h1">JH1</option>
<option value="h2">JH2</option>
<option value="h3">JH3</option>
<option value="h4">JH4</option>
<option value="h5">JH5</option>
</field>
avatar AlexRed
AlexRed - comment - 21 May 2014

but also in the Module Articles Category is possible to specify the item_heading:

<option value="h1">h1</option>
<option value="h2">h2</option>
<option value="h3">h3</option>
<option value="h4">h4</option>
<option value="h5">h5</option>
<option value="h6">h6</option>
<option value="p">p</option>
avatar losedk
losedk - comment - 21 May 2014

I don't if I'm blind, but I can't find that in the xml file :(

avatar AlexRed
AlexRed - comment - 21 May 2014

Yes it is not in the xml file, but it is in the advanced parameter of the module admin and in the database. But if you prefer edit the xml and insert the new item_heading parameter is ok. I think you can also leave the same language string.

avatar AlexRed AlexRed - change - 21 May 2014
Title
Module Articles Category not showing the heading
[#33762] Module Articles Category not showing the heading
avatar AlexRed
AlexRed - comment - 21 May 2014

The pull request for the mod_articles_category.php file
#3626

avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman
brianteeman - comment - 22 Aug 2014

Closed as per the comment on joomlacode

avatar brianteeman brianteeman - change - 22 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-22 10:57:33
avatar brianteeman brianteeman - close - 22 Aug 2014

Add a Comment

Login with GitHub to post a comment