[#36191] - [4.1] Prevent deleting a parent template if children exist
- Fixed in Code Base
- 7 Dec 2021
- Medium
- Build: 4.1-dev
- # 36191
- Diff
- dgrammatiko:4.1-dev—prevent-deleting-parent-if-there-are-children
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
To prevent possible disaster (deleting a parent template but child still around and default) a simple check was added in the installer
Testing Instructions
- Install https://github.com/joomla/joomla-cms/files/7235154/cassy_1.0.0.zip
- Create a child template
- try to uninstall Cassy
Actual result BEFORE applying this Pull Request
The parent template will be removed
Expected result AFTER applying this Pull Request
Error message and parent template wasn't removed
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Libraries |
| Labels |
Added:
Language Change
?
|
||
I have tested this item
Patch works! @dgrammatiko Not related but probably good to mention. I noticed that the icons of the Cassy theme are missing. Also the CSS custom properties of the template styling are missing. Switching to Cassy theme will leave the header transparent.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36191.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36191.
Also the CSS custom properties of the template styling are missing. Switching to Cassy theme will leave the header transparent.
Yes, you're right the template was created for another PR (the wysiwyg tinyMCE) and I haven't updated it since. Probably I will since I want a base template with dark support...
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-07 10:06:23 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
I have tested this item✅ successfully on de5b4ff
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36191.