If I'm not mistaken, this won't work for old Tiny MCE configuration (for example, site updated from older version 4.0.5 and don't change editor settings after update). In that case, set 2 would be used for Super Users and it's not right.

hmhm, yea, I probably better change to krsort() instead of array_reverse().
so it will sort the same for old and new values

Yes, it works. Or we can just use ksort and stop at the first matching set.

// Sort the array, so the items with highest access level goes first
ksort($extraOptionsAll);

// Get configuration depend from User group
foreach ($extraOptionsAll as $set => $val)
{
	$val = (object) $val;
	$val->access = empty($val->access) ? [] : $val->access;

	if (array_intersect($ugroups, $val->access))
	{
		$extraOptions  = $val;
		$toolbarParams = (object) $toolbarParamsAll[$set];
		break;
	}
}

Compare to the current code, it has super tiny improvement because it does not have to loop through all the sets (stop at the first matching). Let me know if you want to make change, otherwise, I will record my test result.

No no, it should not stop on first,
Example if you added some group in two sets (accidentally or in purpose), then it should pick last with higher access level.

Well I would leave it as it is :)

Not a problem. As I mentioned, it is a super tiny improvement :D.

I have tested this item ✅ successfully on 7de6d18

I have tested this item ✅ successfully on 7de6d18

RTC

I have tested this item ✅ successfully on 7de6d18

I have tested this item ✅ successfully on 7de6d18

Thanks!