[#36143] - [4.0] Obsolete code for RTL
- Closed
- 14 Dec 2021
- Medium
- Build: 4.0-dev
- # 36143
- Diff
- brianteeman:more_rtl
User tests: Successful: Unsuccessful:
Removes the code that was added 7 years ago to handle parentheses in RTL being displayed incorrectly in language names
When the code was introduced the LTR text was displayed incorrectly when the document was RTL. Browsers are now better at detection and this code is no longer needed.
To test install any RTL language eg Arabic or Persian Farsi and make that the admin language. Then go to the following links
administrator/index.php?option=com_languages&view=installed&client=1administrator/index.php?option=com_languages&view=languages- and the admin login form
Before this PR it should look like the screenshot below. After the PR it should still look the same.
If after applying the PR you see something like English (en-GB( please mark this as a failed test and report the exact browser and operating system
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields com_languages Modules Installation |
| Labels |
Added:
?
|
||
I have tested this item
All the brackets I saw were correct. However, I did not have any articles or menu items in an rtl language. I am using iranian for testing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36143.
This does not work on Safari 15.1 (17612.2.9.1.20) MacOS Monterey concerning Installed languages
Concerning the admin menu it is wrong before and after patch.
No problem for admin login
weird that it works in one place and not the other
Closed as it doesnt work in safari the new internet explorer 6
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-14 22:29:03 |
| Closed_By | ⇒ | brianteeman |
the drone error is unrelated to this pull request