Please fix the scss code style errors reported here https://ci.joomla.org/joomla/joomla-cms/48730/1/20 . Thanks in advance.

Sorry my mistake. Closed by accident.

I have tested this item ✅ successfully on 458a474

with prebuilt package

I think this PR has some unwanted side effects. It underlines EVERY link in monochrome mode, even the icons.

See the red marks in the following screen shot:

@chmst Is this what you had in mind when reporting the issue? Or did you just refer to the link at the bottom?

I think it needs to be more specific here with the CSS selector.

Fairly certain that the monochrome screenshot was to emphasise the problem of that link and not that the change should be made just for monochrome

@brianteeman Would you say it justifies a negative test in the tracker? Or is it more caused by a probably misleading description of the issue?

It's a negative test because of the issue you reported.
It's not the correct solution if my assumption is correct

@brianteeman I think we think the same: That one link should be underlined regardless of monochrome or not because without monochrome the only visual indicator for it being a link is the colour, and that's not enough. Other links should not be touched if not having the same issue.

I have tested this item ? unsuccessfully on 458a474

With the PR not only that one link is underlined but also other links and even the icons for these links, see the red marks in the screen shot in my comment above #36134 (comment) .

I think a better fix would be to make sure that the one link which has no visual indication at all when monochrome and only the colour when not monochrome should get underlined in any case, regardless of monochrome or not, and the other links should not be touched if they don't have the same problem as thins one link has.

Links looking like buttons and icons attached to the link text should never be underlined in my opinion because that simply looks ugly and has no benefit.

@richard67 @brianteeman Thanks for the feedback. I will do the required changes as suggested and will update the PR accordingly.

I have not tested this item.

sorry did not pay attention to the other underlined links.

Sorry, was absent for a few days. Thank you @khu5h1 for working on that issue. I was surprised myself by this screen as in general we did carefully underline links.
Seems that the new empty-state texts were forgotten.

I have committed the desired changes. Thanks :)

Now after the last change it needs to update title and description because they still refer to monochrome.

@richard67 Thanks for the suggestion. I have updated the title and description of the PR.

I have tested this item ✅ successfully on 4117a51

@khu5h1
thanks for your contribution.
Underlining the link is correct independent from monochrome style. It was an accessibility issue as colorblind users see every screen as monochrome.

@chmst Shouldn't that be done in other places, too, where we have a link at the bottom e.g. of a blank state page?

Yes., but as much as I know there are no other links on "Empty state screens". The update process is something "extra" and it seems overkill now to find generic solutions here.

I have tested this item ✅ successfully on 4117a51

RTC

I have tested this item ✅ successfully on 4117a51

Thx