Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#36128] - [4.1] 'return' is unnecessary as the last statement in a method

? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
26 Nov 2021

code review

avatar PhilETaylor PhilETaylor - open - 26 Nov 2021
avatar PhilETaylor PhilETaylor - change - 26 Nov 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2021
Category ⇒ Administration
avatar HLeithner
HLeithner - comment - 26 Nov 2021

please remove the blank line between the }

avatar PhilETaylor PhilETaylor - change - 26 Nov 2021
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 26 Nov 2021

please remove the blank line between the }

No I just put it back in as @Fedik wants to return again

avatar Fedik Fedik - test_item - 26 Nov 2021 - Tested successfully
avatar Fedik
Fedik - comment - 26 Nov 2021

I have tested this item ✅ successfully on fab6c5f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36128.

avatar HLeithner
HLeithner - comment - 26 Nov 2021

now we have 2 tabs instead of an empty line, I think thats wrong ;-)

avatar PhilETaylor
PhilETaylor - comment - 26 Nov 2021

blame GitHub online editing :(

avatar HLeithner HLeithner - change - 26 Nov 2021
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-11-26 19:48:21
Closed_By ⇒ HLeithner
avatar HLeithner HLeithner - close - 26 Nov 2021
avatar HLeithner HLeithner - merge - 26 Nov 2021
avatar HLeithner
HLeithner - comment - 26 Nov 2021

thanks

Add a Comment

Login with GitHub to post a comment