https://ux.stackexchange.com/questions/123812/is-google-using-the-password-show-hide-toggle-icon-on-their-login-form-correctly

https://ux.stackexchange.com/questions/1318/should-a-toggle-button-show-its-current-state-or-the-state-to-which-it-will-chan

Those two links suggest to me that it is a subjective view. The important thing is what does the user think. In this specific case I think its obvious that clicking the icon will change a hidden password to a visible password

I decided to open that issue after i got confused more than once with the show button's current state.
Although it is subjective, users got used to a specific implementation that is applied almost everywhere and and they use it intuitively.

How could you be confused about the current state when the field will either look like

or

However you are correct that the use of an open and closed icon is not used consistently in Joomla.

How could you be confused about the current state when the field will either look like

The anticipated state does not match the current one and this is confusing.

The anticipated state does not match the current one and this is confusing.

thats a common issue throughout joomla

@sakiss

It seems correct for me on login: Buttons are "call-for-action", not information about the state (icon).

A button says for example "read more" or "hide the content" or "klick me" - and something happens.
Here the button says "hide the password" if the password is plain text.
Or "show plaintext" if the password is hidden.

However you are correct that the use of an open and closed icon is not used consistently in Joomla.

And in other applications also

@chmst When something is used so widely, that users interact with it intuitively, thinking in terms of wrong and right, can be misleading.
It is like changing the sketch in a road sign, just because we think it will be more correct.

We may have to take the general consensus more seriously.
Otherwise we can end up creating idiosyncratic UIs which are great in theory but offer little utility.
Just my opinion :)

Closing as there is a Pull Request. Please test #36195.

For me this is a pointless change. From a straw poll of two sites they both use opposite options. If its changed here now then people will be quite right to submit a pr to reverse it again with the same reasoning. its one of those where 50% of the people will always think its wrong

Twitter

Facebook