No Code Attached Yet
avatar pritam825
pritam825
23 Nov 2021

Summary of Changes
Validated type=number so that the user can not set negative values to follow proper form validation.

Testing Instructions
go to System Dashboard -> Add module to dashboard
Articles-Latest. Try to save the module with Articles to display = any -ve value.
image
image

Actual result BEFORE applying this Pull Request
All the fields with the -ve values will be saved successfully before this pr and doesn't show any error.
image

Expected result AFTER applying this Pull Request
Invalid field message is displayed.

avatar pritam825 pritam825 - open - 23 Nov 2021
avatar joomla-cms-bot joomla-cms-bot - change - 23 Nov 2021
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 23 Nov 2021
avatar richard67
richard67 - comment - 23 Nov 2021

@pritam825 I am confused now. This here is an issue and not a pull request, but you describe it like a pull request. Can it be that you want to make a pull request for the admin modules like the recently merged #36091 did for the site modules, but accidentally have made an issue instead of a pull request?

avatar richard67 richard67 - change - 24 Nov 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-11-24 06:30:08
Closed_By richard67
avatar richard67 richard67 - close - 24 Nov 2021
avatar richard67
richard67 - comment - 24 Nov 2021

Closing as having a pull request. Please test #36100 . Thanks in advance.

avatar pritam825
pritam825 - comment - 24 Nov 2021

@richard67 Sorry for describing like an PR but it's an issue

Add a Comment

Login with GitHub to post a comment