[#36088] - [4.0] Convert relative to absolute urls to for HTML Email Body
- Fixed in Code Base
- 21 Jan 2022
- Medium
- Build: 4.0-dev
- # 36088
- Diff
- joomdonation:fix_html_mail_template
User tests: Successful: Unsuccessful:
Pull Request for Issue #35868.
Summary of Changes
This PR proposes a solution for issue #35868. Basically, it does 3 things:
- Convert none self URLs (for example, link to article.., link to menu item... inserted by editor buttons) to absolute sef urls.
- Convert relative URLs (for example, link to an image...) to absolute URLs
- Show editor buttons in editor so to allow easier insert menu item, article... to HTML mail template.
Most of the code is copied from the System - Sef plugin https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/system/sef/sef.php#L106-L134. I think this should be enough for email content.
Testing Instructions
- Go to System -> Mail Templates, click on Options button in the toolbar, change Mail Format to Html.
- Apply patch
- Edit Global Configuration: Test Mail email template, try to insert image, menu item, article to the template
- Go to System -> Global Configuration, try to send test mail. Check the received image, make sure the image is displayed, link to menu item, article is accessible. It is not working before this PR (you can test it by revert PR, then resend the email, these content won't be accessible anymore)
Actual result BEFORE applying this Pull Request
Images not being displayed, links... are not accessible in the email.
Expected result AFTER applying this Pull Request
Images are being displayed properly, links... are accessible in the email.
Documentation Changes Required
None.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Libraries |
Quy
- | Labels |
Added:
?
|
||
@dgrammatiko We don't know if this is supported, and I even unsure where and how we should add that base tag in email content, so I will stay with the current solution.
@dgrammatiko We don't know if this is supported, and I even unsure where and how we should add that base tag in email content, so I will stay with the current solution.
The whole mail thing in Joomla is a huge hack. There should have been a document type email and then most things could follow the architecture...
I have tested this item
Convert relative URLs (for example, link to an image...) to absolute URLs.
WORK
Show editor buttons in editor so to allow easier insert menu item, article... to HTML mail template.
WORK
Convert none self URLs (for example, link to article.., link to menu item... inserted by editor buttons) to absolute sef urls.
WORK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36088.
To add further confirmation:
Convert relative URLs (for example, link to an image...) to absolute URLs.
WORK
Show editor buttons in editor so to allow easier insert menu item, article... to HTML mail template.
WORK
Convert none self URLs (for example, link to article.., link to menu item... inserted by editor buttons) to absolute sef urls.
WORK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36088.
| Status | Pending | ⇒ | Ready to Commit |
I set the test result for @aftertaf manually. Set this to RTC after 2 successful tests.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36088.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36088.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36088.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36088.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-21 22:05:26 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
@joomdonation out of curiosity injecting a base tag in the head wouldn't be easier
<base href="<?php echo Uri::root(false)" />?Context: https://www.caniemail.com/ doesn't show which clients support this tag but this issue hteumeuleu/caniemail#199 probably implies that the tag is widely supported
I'm NOT an email expert!!!