No Code Attached Yet
avatar philowantage
philowantage
18 Nov 2021

Steps to reproduce the issue

Under the Template: Options there is a selection for Preview Module Positions. When this is Enabled and the URL of the site is appended with ?tp=1, all positions should be displayed even if there are no modules loaded into them.

Expected result

All positions should be displayed.

Actual result

Casiopeia has 16 positions, but only 5 are displayed when no modules are loaded on the page. i.e. topbar, below-top, breadcrumbs, main-top, main-bottom and debug.

System information (as much as possible)

Under normal operation templates use the countModules() function to decide if a module position should be displayed.

Additional comments

There is no point in the Position Preview if you can't see everything. i.e. All 16 positions in Casiopeia.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar philowantage philowantage - open - 18 Nov 2021
avatar philowantage philowantage - change - 18 Nov 2021
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 18 Nov 2021
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 18 Nov 2021
avatar brianteeman
brianteeman - comment - 18 Nov 2021

For reference the pull request that should make this work was #29521

avatar brianteeman
brianteeman - comment - 18 Nov 2021

The PR that broke the behaviour was #35225 and specifically in this code.

// Return early if only the content is required
if (!empty($attribs['contentOnly']))
{
return $module->content;
}

Sorry I dont understand it enough to fix it.

avatar chmst
chmst - comment - 20 Nov 2021

See also #34743 tests are welcome!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36071.

avatar brianteeman
brianteeman - comment - 20 Nov 2021

#34743 is completely unrelated and I just confirmed that when testing #34743 the issue reported here is still present

avatar Fedik Fedik - close - 8 Dec 2021
avatar Fedik
Fedik - comment - 8 Dec 2021

Pleas test #36268

avatar Fedik Fedik - change - 8 Dec 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-12-08 16:46:04
Closed_By Fedik

Add a Comment

Login with GitHub to post a comment