? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Nov 2021

With J4 we are seeing more people switching to use tinymce. This has just re-emphasised the terrible ui where people do not realise that everything is configured per set. And as the first set that is displayed is set 2 ie not the one for a super admin they make a change to the plugin config and nothing happens.

This PR attempts to go some way to fixing that by

  1. switching from bootstrap tabs to the joomla-tab webcomponent
  2. changing the order so that set 0 is first and not last
  3. clarifying the plugin description

This is really just a subtle change but it appears to make it more obvious that everything is in a set.

Before

image

After

image

avatar brianteeman brianteeman - open - 16 Nov 2021
avatar brianteeman brianteeman - change - 16 Nov 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Nov 2021
Category Administration Language & Strings Layout
avatar brianteeman
brianteeman - comment - 16 Nov 2021

@PhocaCz your issue inspired me to propose this change it would be great to get some feedback if you think it does or doesn't make it clearer about the sets

avatar PhocaCz
PhocaCz - comment - 16 Nov 2021

Hi,

  • 3: OK

  • 2: OK

  • 1: Hard to say, I don't know the overall concept and I don't know which type of the following types would be most appropriate for the list. If

a) current list
img

or

b) list of global configuration type
img

or

c) list of standard edit tabs
img

Hard to say. ?

Anyway tested successfully.

avatar PhocaCz PhocaCz - test_item - 16 Nov 2021 - Tested successfully
avatar PhocaCz
PhocaCz - comment - 16 Nov 2021

I have tested this item successfully on abfe2f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36066.

avatar Fedik
Fedik - comment - 17 Nov 2021

Need to make sure that previous saved parameters not lost after this changes.
If it works then it good :)

avatar brianteeman brianteeman - change - 17 Nov 2021
Labels Added: Language Change ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 Nov 2021
Category Administration Language & Strings Layout Administration Language & Strings Layout Front End Plugins
avatar brianteeman
brianteeman - comment - 17 Nov 2021

Yes that was the first thing checked. Its just a paint job

avatar pritam825 pritam825 - test_item - 17 Nov 2021 - Tested successfully
avatar pritam825
pritam825 - comment - 17 Nov 2021

I have tested this item successfully on 1e37d40


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36066.

44bc583 17 Nov 2021 avatar brianteeman oops
avatar richard67 richard67 - alter_testresult - 17 Nov 2021 - pritam825: Tested successfully
avatar richard67
richard67 - comment - 17 Nov 2021

I've restored @pritam825 's test result since the commit after that which has invalidated it was just a full stop being added to the language strings.

c4c0866 17 Nov 2021 avatar brianteeman tabs
avatar richard67 richard67 - alter_testresult - 17 Nov 2021 - @pritam825: Tested successfully
avatar richard67
richard67 - comment - 17 Nov 2021

Added back again pritam825's test result as the last change was just code style.

@PhocaCz Could you test again? There has been a change on how the sorting was implemented. It still should work the same way as it did in your previous test. Thanks in advance.

avatar PhocaCz PhocaCz - test_item - 17 Nov 2021 - Tested successfully
avatar PhocaCz
PhocaCz - comment - 17 Nov 2021

I have tested this item successfully on c4c0866

Tested again (18.11.2021)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36066.

avatar richard67 richard67 - change - 17 Nov 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 17 Nov 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36066.

avatar chmst chmst - change - 19 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-19 16:47:37
Closed_By chmst
Labels Added: ?
avatar chmst chmst - close - 19 Nov 2021
avatar chmst chmst - merge - 19 Nov 2021
avatar chmst
chmst - comment - 19 Nov 2021

Great improvement, thanks!

avatar brianteeman
brianteeman - comment - 19 Nov 2021

thanks

Add a Comment

Login with GitHub to post a comment