? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
16 Nov 2021

Summary of Changes

When using an image list custom field. The template needs to have an absolute path. It is a regression from #30784.

We discovered this in DPCalendar when custom fields are rendered for invoices. As I can't offer a test case this one needs to go by code review. It is pretty obvious when you check the Image::getImageFileProperties function.

Testing Instructions

Somehow it needs to render a custom field in the back end which is not possible in core atm.

avatar laoneo laoneo - open - 16 Nov 2021
avatar laoneo laoneo - change - 16 Nov 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Nov 2021
Category Front End Plugins
avatar laoneo laoneo - change - 16 Nov 2021
The description was changed
avatar laoneo laoneo - edited - 16 Nov 2021
avatar dgrammatiko
dgrammatiko - comment - 16 Nov 2021

This Field is still not compatible with external adapters... ? Shouldn't it be?

avatar laoneo
laoneo - comment - 16 Nov 2021

Nope, it is about local images and not media manager.

avatar laoneo
laoneo - comment - 1 Dec 2021

@wilsonge this here is code review only as I can't find a use case where this can be tested in core.

avatar laoneo
laoneo - comment - 15 Dec 2021

@wilsonge can you please consider this into the next release? If you check the argument here https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Image/Image.php#L175 then you can clearly see that the full path is needed and not the one relative to the index.php

avatar laoneo laoneo - change - 3 Jan 2022
Labels Added: ?
avatar wilsonge wilsonge - change - 5 Jan 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-01-05 00:59:08
Closed_By wilsonge
avatar wilsonge wilsonge - close - 5 Jan 2022
avatar wilsonge wilsonge - merge - 5 Jan 2022
avatar wilsonge
wilsonge - comment - 5 Jan 2022

Thanks!

Add a Comment

Login with GitHub to post a comment