? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar ghazal
ghazal
15 Nov 2021

Please see #36038

avatar ghazal ghazal - open - 15 Nov 2021
avatar ghazal ghazal - change - 15 Nov 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Nov 2021
Category NPM Change
avatar richard67
richard67 - comment - 15 Nov 2021

@ghazal You need to update the package-lock.json, too. For this you run the command "composer update postcss" on a command line in the Joomla root folder after having applied the changes of this PR on the package.json file.

avatar brianteeman
brianteeman - comment - 15 Nov 2021

For reference https://evilmartians.com/chronicles/postcss-8-plugin-migration any postcss plugin in use needs to be checked to ensure it works with v8

avatar dgrammatiko
dgrammatiko - comment - 15 Nov 2021

Please close this PR as it's wrong and test #32574 that does the upgrade correctly

avatar richard67
richard67 - comment - 15 Nov 2021

Please close this PR as it's wrong and test #32574 that does the upgrade correctly

@dgrammatiko #32574 is for 4.1-dev. Should we wait until 4.1 with that update, or should we do that for 4.0-dev so it can be fixed with the upcoming next release?

avatar dgrammatiko
dgrammatiko - comment - 15 Nov 2021

Should we wait until 4.1 with that update, or should we do that for 4.0-dev so it can be fixed with the upcoming next release?

PostCSS 7.x is still working (tests don't throw) AFAIK

avatar ghazal
ghazal - comment - 15 Nov 2021

npm v 8.1.3
node v 17.0.1
Composer v 2.1.12

I began to get errors with PostCSS after I updated to the above versions, ie this PR.
But I had not noticed @dgrammatiko PR.
Well, as tests are failing, I close this.

avatar ghazal ghazal - change - 15 Nov 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-11-15 10:37:15
Closed_By ghazal
Labels Added: ? NPM Resource Changed
avatar ghazal ghazal - close - 15 Nov 2021
avatar dgrammatiko
dgrammatiko - comment - 15 Nov 2021

@richard67 fwiw #36050 also upgrades PostCSS to 8.x and it's on 4.0.x

avatar richard67
richard67 - comment - 15 Nov 2021

@dgrammatiko Thanks!

Add a Comment

Login with GitHub to post a comment