[#36047] - [4.0] Do not force the change of uploaded mm files to lowercase
- Fixed in Code Base
- 30 Dec 2021
- Medium
- Build: 4.0-dev
- # 36047
- Diff
- Digital-Peak:j4/upload/lower
User tests: Successful: Unsuccessful:
Pull Request for Issue #35808.
Summary of Changes
In the media manager all file names are changed to lower case on upload. This behavior was introduce in #28002 and works only when the INTL extension is installed. Not sure if lower case is intended to be added as well, @infograf768 can shed perhaps some light into this.
This pr reverts the lower case check.
The history of this changes can be traces back to 2016:
Testing Instructions
- Make sure the INTL extension is installed on your host.
- Upload an image with upper case characters in media manager.
Actual result BEFORE applying this Pull Request
Image file name is changed to lowercase.
Expected result AFTER applying this Pull Request
Image file name keeps upper case characters.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
Confirmed - case is preserved on upload to media folder.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36047.
@laoneo I think the title of this PR is misleading because of a mistake in translation to English commonly made by German native speakers.
"Must not" is not the opposite of "must" in English language like one would think if not English native speaker, it has a different meaning.
The opposite of "must" is "not need to" or "don't have to", while "must not" has the meaning of "shall not" or "may not" or "are not allowed to".
So "Must not be lower case" doesn't mean that they may me upper or lower case case, it means they have to be uppercase, and that's wrong.
I suggest to change the title to "MM uploads don't have to be lower case" or "Allow MM uploads to be upper case, too" or something like that.
From the issue as described I think a more accurate title would be "Do not force the change of uploaded mm files to lowercase"
From the issue as described I think a more accurate title would be "Do not force the change of uploaded mm files to lowercase"
Yes, that would be best.
| Title |
|
||||||
Not sure if lower case is intended to be added as well, @infograf768 can shed perhaps some light into this.
I guess the intention was to normalize results for all languages, including those not using uppercase letters like
Chinese, Korean, Arabic, Japanese, Indic languages (Hindi, Bengali, Tamil, Gujarati, Marathi, etc.), Thai, etc.
See https://www.quora.com/Which-languages-have-no-capitalized-letter for an extensive list of 46 languages (add there their subs)
Scripts including uppercases are those based on Armenian, Cyrillic, Greek, Latin
Just a matter of choice. There were some comments about making these names url safe, therefore lowercase.
I have tested this item
Patch works!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36047.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36047.
Can this be integrated please.
I use fields to make PDF-files available for download. By changing the file names from the media manager to lower case, the result in the frontend looks as if the website operator is not interested in correct spelling. At the moment I can only help myself by uploading the PDF files with the correct filenames via FTP.
The is RTC, ready to commit, so it very likely will go into the next release.
Yelling will not speed that up.
Sorry, I didn't know the workflow here and didn't want to jostle. I just wanted to draw attention to one use case.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-30 21:15:41 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
who would have guessed that an untested pull requested would have caused problems?