? ? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
14 Nov 2021

remove skipto override as its fixed upstream
remove metis-toggler as its a duplicate
change metis-toggler to use logical operators
change navbar-brand to use logical operators
change jmodedit to use logical operators

avatar brianteeman brianteeman - open - 14 Nov 2021
avatar brianteeman brianteeman - change - 14 Nov 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Nov 2021
Category Repository NPM Change Front End Templates (site)
avatar brianteeman brianteeman - change - 14 Nov 2021
Labels Added: ? NPM Resource Changed
avatar brianteeman brianteeman - change - 14 Nov 2021
The description was changed
avatar brianteeman brianteeman - edited - 14 Nov 2021
avatar khu5h1 khu5h1 - test_item - 14 Nov 2021 - Tested successfully
avatar khu5h1
khu5h1 - comment - 14 Nov 2021

I have tested this item successfully on bacf8ff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36040.

avatar Shubhamverma2796 Shubhamverma2796 - test_item - 14 Nov 2021 - Tested successfully
avatar Shubhamverma2796
Shubhamverma2796 - comment - 14 Nov 2021

I have tested this item successfully on bacf8ff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36040.

avatar HLeithner
HLeithner - comment - 14 Nov 2021

If I'm correct we don't use inset-inline-end till now, is it save for us to use it?

avatar brianteeman
brianteeman - comment - 14 Nov 2021
avatar richard67 richard67 - change - 14 Nov 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 14 Nov 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36040.

avatar pritam825 pritam825 - test_item - 15 Nov 2021 - Tested successfully
avatar pritam825
pritam825 - comment - 15 Nov 2021

I have tested this item successfully on bacf8ff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36040.

avatar infograf768
infograf768 - comment - 16 Nov 2021

Screen Shot 2021-11-16 at 08 47 53

avatar HLeithner
HLeithner - comment - 16 Nov 2021

I have seen this too JM, and I think it breaks our policy CURRENT - 2 (also current depends of the time of the major or minor release, but I'm not sure on this topic).

based on this information all PRs including 'inset-inline-end' is too early for us but have to be discussed by production

avatar brianteeman
brianteeman - comment - 16 Nov 2021

i thought it was changed to current -1

avatar HLeithner
HLeithner - comment - 16 Nov 2021

#PROD2019/005 - Change minimum version requirements for all browsers to n-2 and drop support for Internet Explorer. (per 19/05/16)

was the last motion I found... should be moved to the development strategy

avatar C-Lodder
C-Lodder - comment - 16 Nov 2021

@HLeithner Your package.json states otherwise:

"browserslist": [
    "last 1 version",
    "not ie < 11"
],
avatar brianteeman
brianteeman - comment - 16 Nov 2021

and before that it was in settings.json where it was merged 5july 2018

avatar infograf768
infograf768 - comment - 16 Nov 2021

FYI, concerning Safari versions: 14.1 was an update for Mac OS Big Sur, i.e. all former versions of MacOS using Safari 14 or lower will not be compatible. Mac OS Monterey has Safari 15.

avatar HLeithner
HLeithner - comment - 16 Nov 2021

@HLeithner Your package.json states otherwise:

"browserslist": [
    "last 1 version",
    "not ie < 11"
],

then the package.json is wrong and has to be fixed

avatar C-Lodder
C-Lodder - comment - 16 Nov 2021

lol, after 3 and a half years?
Sounds like the motion was incorrectly written without prior research.

avatar HLeithner
HLeithner - comment - 16 Nov 2021

lol, after 3 and a half years? Sounds like the motion was incorrectly written without prior research.

no idea why it's funny when an error happens. we have 15 year old bugs.

avatar brianteeman
brianteeman - comment - 16 Nov 2021

I leave it to those far more important than me to decide. note that the settings are used to determine if autoprefix etc needs to do something to ensure old browser support

avatar brianteeman
brianteeman - comment - 16 Nov 2021

Changing to last 2 version will result in a massive amount of changes to the css generated by the autoprefixer. As a very quick example we will see the following changes in build_incomplete.html

image

avatar richard67
richard67 - comment - 18 Nov 2021

Setting RLDQ label so release leads can decide about usage of inset-inline regarding our browser support policy.

avatar brianteeman
brianteeman - comment - 18 Nov 2021

Further information. Please remember that we have been wrorking and testing with last 1 version for 3.5 years. If you rebuild the current css with last 2 version you will see how much is different - about 9% bigger. (these tests are without by pull requests as they're not merged)

CSS Line Count

Template last 1 version last 2 version
Atum 14516 15884
Atum RTL 14807 16145
Cassiopeia 13552 14845
Cassiopeia RTL 13829 15122
avatar wilsonge
wilsonge - comment - 28 Nov 2021

FYI, concerning Safari versions: 14.1 was an update for Mac OS Big Sur, i.e. all former versions of MacOS using Safari 14 or lower will not be compatible. Mac OS Monterey has Safari 15.

So based on this high sierra is the highest OSX version that is affected by this but already had no security support when Joomla 4.0.0 came out (security support ended december 2020). Given our CSS is already bugged in terms of giving support for this version as well I don't think it's a big deal merging these Pull Requests at this moment in time. Especially given the big savings we get in maintainability.

avatar wilsonge wilsonge - change - 28 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-28 17:14:21
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 28 Nov 2021
avatar wilsonge wilsonge - merge - 28 Nov 2021
avatar richard67
richard67 - comment - 28 Nov 2021

@wilsonge Thanks for this decision which I fully support.

avatar brianteeman
brianteeman - comment - 28 Nov 2021

Thanks for making a sensible decision.

Add a Comment

Login with GitHub to post a comment