User tests: Successful: Unsuccessful:
remove skipto override as its fixed upstream
remove metis-toggler as its a duplicate
change metis-toggler to use logical operators
change navbar-brand to use logical operators
change jmodedit to use logical operators
Status | New | ⇒ | Pending |
Category | ⇒ | Repository NPM Change Front End Templates (site) |
Labels |
Added:
?
NPM Resource Changed
|
I have tested this item
If I'm correct we don't use inset-inline-end
till now, is it save for us to use it?
Perfectly safe to use https://caniuse.com/?search=inset-inline-end
Status | Pending | ⇒ | Ready to Commit |
RTC
I have tested this item
I have seen this too JM, and I think it breaks our policy CURRENT - 2 (also current depends of the time of the major or minor release, but I'm not sure on this topic).
based on this information all PRs including 'inset-inline-end' is too early for us but have to be discussed by production
i thought it was changed to current -1
#PROD2019/005 - Change minimum version requirements for all browsers to n-2 and drop support for Internet Explorer. (per 19/05/16)
was the last motion I found... should be moved to the development strategy
@HLeithner Your package.json
states otherwise:
"browserslist": [
"last 1 version",
"not ie < 11"
],
and before that it was in settings.json
where it was merged 5july 2018
FYI, concerning Safari versions: 14.1 was an update for Mac OS Big Sur, i.e. all former versions of MacOS using Safari 14 or lower will not be compatible. Mac OS Monterey has Safari 15.
@HLeithner Your
package.json
states otherwise:"browserslist": [ "last 1 version", "not ie < 11" ],
then the package.json is wrong and has to be fixed
lol, after 3 and a half years?
Sounds like the motion was incorrectly written without prior research.
lol, after 3 and a half years? Sounds like the motion was incorrectly written without prior research.
no idea why it's funny when an error happens. we have 15 year old bugs.
I leave it to those far more important than me to decide. note that the settings are used to determine if autoprefix etc needs to do something to ensure old browser support
Setting RLDQ label so release leads can decide about usage of inset-inline regarding our browser support policy.
Further information. Please remember that we have been wrorking and testing with last 1 version
for 3.5 years. If you rebuild the current css with last 2 version
you will see how much is different - about 9% bigger. (these tests are without by pull requests as they're not merged)
Template | last 1 version | last 2 version |
---|---|---|
Atum | 14516 | 15884 |
Atum RTL | 14807 | 16145 |
Cassiopeia | 13552 | 14845 |
Cassiopeia RTL | 13829 | 15122 |
FYI, concerning Safari versions: 14.1 was an update for Mac OS Big Sur, i.e. all former versions of MacOS using Safari 14 or lower will not be compatible. Mac OS Monterey has Safari 15.
So based on this high sierra is the highest OSX version that is affected by this but already had no security support when Joomla 4.0.0 came out (security support ended december 2020). Given our CSS is already bugged in terms of giving support for this version as well I don't think it's a big deal merging these Pull Requests at this moment in time. Especially given the big savings we get in maintainability.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-28 17:14:21 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
?
|
Thanks for making a sensible decision.
I have tested this item✅ successfully on bacf8ff
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36040.