[#36023] - Fix uploadlimits checks
- Fixed in Code Base
- 4 Jan 2022
- Medium
- Build: 4.0-dev
- # 36023
- Diff
- HLeithner:j4/uploadlimits
User tests: Successful: Unsuccessful:
Pull Request for Issue #35853
Summary of Changes
check if upload, post and memory limit is set to unlimited before checking required minimum limits
Testing Instructions
Install extensions
Upload file in media manger.
if possible with different values set in for upload_max_filesize, post_max_size, memory_limit in php.ini
Actual result BEFORE applying this Pull Request
doesn't work if any of the 3 vars is <= 0
Expected result AFTER applying this Pull Request
works
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer com_media |
| Labels |
Added:
?
|
||
Ive said it before. Repeatedly. memory_limit doesn't effect uploading of files! Basic PHP.
I would say the same but there are 2 "problems"
First it's mentioned in the documentation https://php.itronic.at/manual/en/ini.core.php#ini.post-max-size
Generally speaking, memory_limit should be larger than post_max_size.
If you look at the mediamanager then you will see that it loads the images as base64 encoded string...
sure both things doesn't effect the upload directly but is a failsafe for later usage. Does you see a negative impact?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36023.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36023.
| Status | Pending | ⇒ | Ready to Commit |
R2C
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36023.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-04 00:37:59 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Ive said it before. Repeatedly. memory_limit doesn't effect uploading of files! Basic PHP.
#35360 (comment)
#35392 (comment)