if you do it this way you have to modify the php code to allow "0" as no limit option.

Before:

Clearly visible that the maximum count is 20

After:

Now user can set the value of the maximum count.

I have tested this item ✅ successfully on 38eb9e9

I have tested this item ✅ successfully on 38eb9e9

I followed the test instructions and the patch worked as described.

RTC

@HLeithner requested valid changes. please remove RTC

oops missed that

@HLeithner default is 5 as in other modules. The value 0 is not really useful, of course, as the result then would be empty, but for mysql this is not a problem.
If I change it here ( 0 = all), we must change it in all other modules too.

@HLeithner default is 5 as in other modules. The value 0 is not really useful, of course, as the result then would be empty, but for mysql this is not a problem. If I change it here ( 0 = all), we must change it in all other modules too.

That's the reason I requested the implementation for this case in php (check for 0 and remove the setlimit call)

Made the changes as requested by @HLeithner . Only if the input is > 0, the maximum number is set as limit. Could you please re-test? @BertaOctech @Shubhamverma2796 ? Thanks!

Back to pending.

@chmst I applied the path and here are the results:

As you can clearly see the maximum tag value can be set as negative too. I think you should set the lower limit to 0 because obviously there is no point in setting -ve values.

The min attribute in the number field is not validated. Also with min=0 it is possible to enter every negative value. This is not in scope of this PR.

@chmst Why closed?

@Shubhamverma2796 would you like to open an issue for the bug you found in joomla? #36019 (comment)
Maybe you also find a solution ;)

@chmst How can I open an issue because this PR is closed before getting merged, and the hard limit is still 20. Please correct me if I'm wrong.

The hard limit is independent from this. You found out, that it is possible to enter a negative value into a field of type="number" , also when the attribute min="0" is set. The field does not validate the input.

You can open a new issue here

and write a bug report. If you want ;)

@chmst In the above video, you can see that I've fixed the issue; whenever the user tries to input any -ve value, the value automatically gets changed to 0. In this way, we can easily prevent the user from entering any negative value.
The problem is I am new here and not well-versed with the PHP and code structure of Joomla. Therefore, I cannot figure out where(in which file or folder) I should put the function written by me so that everything works fine. If anyone can guide me, then it would be my pleasure.
Thanks

Link to the function

@Shubhamverma2796 javascript is not the solution

The min attribute in the number field is not validated. Also with min=0 it is possible to enter every negative value. This is not in scope of this PR.

Just add validate="number" and this will ensure that the min=0 is validated

@chmst should I open a new pr for #36016 or will you re-open this pr itself?