? NPM Resource Changed Pending

User tests: Successful: Unsuccessful:

avatar khu5h1
khu5h1
10 Nov 2021

Pull Request for Issue #36002 .

Summary of Changes

Solved max-width overwritten problem by removing property max-width: none.

Actual result BEFORE applying this Pull Request

max-width was overwritten by max-width: none.

Expected result AFTER applying this Pull Request

max-width overwritten problem solved.

Documentation Changes Required

No

avatar khu5h1 khu5h1 - open - 10 Nov 2021
avatar khu5h1 khu5h1 - change - 10 Nov 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Nov 2021
Category Front End Templates (site) NPM Change
avatar brianteeman
brianteeman - comment - 10 Nov 2021

I am unable to replicate the problem that this is supposed to solve

avatar brianteeman
brianteeman - comment - 11 Nov 2021

#36002 has been closed so I guess this should be as well #36002 (comment)

avatar richard67 richard67 - change - 11 Nov 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-11-11 09:45:19
Closed_By richard67
Labels Added: ? NPM Resource Changed
avatar richard67
richard67 - comment - 11 Nov 2021

@khu5h1 Thank you for your pull request. But the issue which it shall solve has meanwhile been identified as not an issue but expected behaviour, see the comments there (also linked in the previous comment here). So I'm closing this PR. I hope this doesn't discourage you from further contributions. That can happen to anyone of us.

avatar richard67 richard67 - close - 11 Nov 2021
avatar khu5h1
khu5h1 - comment - 11 Nov 2021

@richard67 Thank you for your comment. I totally understood that this is the expected behavior. And it is fine to close this PR.
This is not discouraging at all as I got better experience with Joomla code base while creating this PR for the issue and that's very encouraging. :)

Add a Comment

Login with GitHub to post a comment