User tests: Successful: Unsuccessful:
Pull Request for Issue #35946 .
Same as #35981 but for 3.10-dev.
This pull request (PR) changes the input filter type from "cmd" to "string" in the extension installer's language adapter so that spaces and parenthesis are not removed anymore from the extension name in database so that error messages show it right.
In opposite to other extension types where language strings might be provided to translate the name, names of languages should never be translated, neither the English name nor the native name.
That's why there is no need to use the "cmd" filter like it would be when using the name to construct a language string constant from it.
PR #35981 which does the same as this one here but for 4.0-dev has already been merged.
Check the names of the site and the admin languages in database e.g. with phpMyAdmin.
Result: In opposite to the core English languages, the names of the just installed site and admin languages have spaces and parenthesis stripped off.
Go to "Extensions - Manage - Manage" and try to uninstall some of the previously installed language packs' admin or site languages.
Result: The warning alert shows the name as it is in database.
Apply the patch of this PR.
Make sure that you have switched on "Debug System" and set "Error Reporting" to "Maximum" or "Development" in Global Configuration so you would see any errors happening in the next steps.
Go to "Extensions - Manage - Update", if necessary use the buttons to clear cache and to check for updates and then update the 2 old language packs.
Go to "Extensions - Manage - Install Languages" and install some more language(s) suitable for the test, e.g. French (Canada) and German (Switzerland).
Check again the names in database.
Result: The names are as specified in the site and admin language's manifest XML files, no spaces or parenthesis have been stripped off. This is true for both the updated and the newly installed languages.
Go to "Extensions - Manage - Manage" and try again to uninstall some of the site or admin languages.
Result: The warning alert shows the name as it is in database, and that's ok now.
See testing instructions steps 2 and 3.
See testing instructions steps 8 and 9.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
I have tested this item
I have test this successfully on Joomla! 3.10.3
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
RTC
I have tested this item
Taking this in thanks folks :)
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-21 13:32:14 |
Closed_By | ⇒ | zero-24 | |
Labels |
Added:
?
|
Thanks all.
I have tested this item✅ successfully on d35fc59
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35980.