[#35978] - [4.0] Fix wrong pre-update checker behavior
- Fixed in Code Base
- 7 Nov 2021
- Medium
- Build: 4.0-dev
- # 35978
- Diff
- joomdonation:fix_preupdate_checker
User tests: Successful: Unsuccessful:
Pull Request for Issue #35904.
Summary of Changes
Currently, when you update from your Joomla 4.0.x installation to latest Joomla version, the pre-update checked is always be displayed. The right behavior is it should only be displayed if:
- You update to next Joomla major release (Joomla 5)
- Or there is a PHP requirement does not meet (all the requirements are checked inside this method https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php#L1085)
This PR just fixes that wrong behavior.
Testing Instructions
- Go to System ->Update -> Joomla. Click on Options button in the toolbar, set:
- Update Channel to Custom URL
- Custom URL to https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/35972/downloads/48267/pr_list.xml (this is update URL for this PR #35972)
Save it
- The system should find a new Joomla update
Actual result BEFORE applying this Pull Request
Pre-update checker is still being displayed while it should not because you are not updating to new major release (Joomla 5)
Expected result AFTER applying this Pull Request
Pre-update checker is not being displayed anymore. Update screen is displayed to allow you to perform the update.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
I have tested this item
After PR the Pre-update check did not show. Changed the update URL to nightly and the pre-update check is now shown as to expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35978.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35978.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-07 02:31:27 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
?
|
||
Thx
I have tested this item✅ successfully on 1afa83e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35978.