Composer Dependency Changed ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
5 Nov 2021

Pull Request for Issue # .

Summary of Changes

Is seem that when PR #33908 was merged, it has added back a line in the composer.json file which had been removed by @wilsonge in the 4.0-dev branch with this commit dd22c22 .

The result is a duplicate entry for joomla/mediawiki, see the first and the last line of following code part: https://github.com/joomla/joomla-cms/blob/4.0-dev/composer.json#L91-L97

This pull request (PR) here removes the duplicate in line 91 coming from PR #33908 and keeps the one in line 97 from @wilsonge 's commit.

As the resolved version1.0.0 for joomla/mediawiki does not change, there are no changes in the composer.lock file besides the api version and the checksum. But it needs these changes in the lock file in order not to get a warning that it's not updated.

Testing Instructions

  1. On a clean, current 4.0-dev branch, run composer install and note the first line of the output created by composer.
    Result: Key joomla/mediawiki is a duplicate in ./composer.json at line 97

  2. Check in the composer.lock file if the section for dependency "joomla/mediawiki" looks like here regarding the version number, the URLs and checkums and the date and time: https://github.com/joomla/joomla-cms/blob/4.0-dev/composer.lock#L6896-L6956
    Result: It's the same.

  3. Apply the patch from this PR.

  4. Repeat step 1.
    Result: Installing dependencies from lock file (including require-dev), i.e. no duplicate reported anymore.

  5. Repeat step 2.
    Result: It's still the same.

Actual result BEFORE applying this Pull Request

Notice Key joomla/mediawiki is a duplicate in ./composer.json at line 97 when running composer install.

Expected result AFTER applying this Pull Request

No notice Key joomla/mediawiki is a duplicate in ./composer.json at line 97 when running composer install.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 5 Nov 2021
avatar richard67 richard67 - change - 5 Nov 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Nov 2021
Category External Library Composer Change
avatar richard67 richard67 - change - 5 Nov 2021
The description was changed
avatar richard67 richard67 - edited - 5 Nov 2021
avatar richard67
richard67 - comment - 5 Nov 2021

Ping @wilsonge .

avatar wilsonge wilsonge - close - 7 Nov 2021
avatar wilsonge wilsonge - merge - 7 Nov 2021
avatar wilsonge wilsonge - change - 7 Nov 2021
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-07 19:49:47
Closed_By wilsonge
Labels Added: Composer Dependency Changed ?
avatar wilsonge
wilsonge - comment - 7 Nov 2021

Thanks!

avatar richard67
richard67 - comment - 7 Nov 2021

Thanks

Add a Comment

Login with GitHub to post a comment