Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#3597] - PHP syntax error in comparison in users controller (frontend)

? Success

User tests: Successful: Unsuccessful:

avatar Dekari
Dekari
16 May 2014

Changed line 65 from :

if ($options['remember'] = true) to

if ($options['remember'] == true)

The comparison had syntax error and seems to turn into "remember" always whoever logged.

based on tracker issue #33735

avatar Dekari Dekari - open - 16 May 2014
avatar Dekari
Dekari - comment - 16 May 2014

Yes a small detail i saw when making a custom component :)

avatar Bakual
Bakual - comment - 16 May 2014

PR looks fine.
When testing make sure remember-me works as expected.

Adjusted title of PR to match the tracker title.

avatar Dekari
Dekari - comment - 16 May 2014

Ok i will check on it

avatar vdespa
vdespa - comment - 26 Jul 2014

This PR does not fix anything and needs to be closed. $options['remember'] always seems to come as false.

avatar Bakual Bakual - change - 27 Jul 2014
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-07-27 16:25:25
avatar Bakual Bakual - close - 27 Jul 2014

Add a Comment

Login with GitHub to post a comment