[#35963] - Display contact without icons
- Fixed in Code Base
- 7 Nov 2021
- Medium
- Build: 4.0-dev
- # 35963
- Diff
- chmst:contact-display-icons
User tests: Successful: Unsuccessful:
Pull Request for Issue #35961 .
Summary of Changes
Check if icons may be shown in a contact.
Testing Instructions
You need at least one contact and a menu item to this contact.
Go to com_contact in Backend, Open the Options and go to Icons settings.
Set the select to "text": In the frontend. The contact shows text:
Select "none": No icon or text is displayed:
Select "icons" and don't choose an own image: The default icons are displayed.
Select "icons" and choose own images: Own images replace the default icons
Actual result BEFORE applying this Pull Request
Icons were displayed when the selection was "none"
Expected result AFTER applying this Pull Request
No Icons are displayed when the selection is "none"
Documentation Changes Required
no, it's a bug
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
This PR is a duplicate to #35962, because the issue tracker messed it all up
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35963.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35963.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35963.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35963.
Thank you all, sorry for inconvenience with the issue tracker
| Labels |
Added:
?
|
||
I have tested this item
The last change was just a removal of useless brackets since in PHP the "==" operator has higher precedence than the "=" operator, so just a code style change and my previous test is still valid.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35963.
@brianteeman Could you test again? A code review of the last commit should be sufficient. Thanks in advance.
As only brackets were removed, the old test should be still valid.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-07 02:35:18 |
| Closed_By | ⇒ | bembelimen |
Thx
I have tested this item✅ successfully on 1537182
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35963.