[#35960] - Notification subject: Use Item title, not model name
- Fixed in Code Base
- 28 Nov 2021
- Medium
- Build: 4.0-dev
- # 35960
- Diff
- chmst:workflow-notification-plugin-mailsubject
User tests: Successful: Unsuccessful:
Pull Request for Issue #35958 .
Summary of Changes
As mentioned in #35958 (comment) the subject of a notification now contains the title of the item.
Testing Instructions
For testing this PR you should have an active own workflow, where a transition triggers a notification.
Perform this transition.
The notification contains a subject and a message body.
Actual result BEFORE applying this Pull Request
Subject is: The status of an Article has been changed
where "Article" is a model Name and cannot be translated.
Expected result AFTER applying this Pull Request
Subject is: The status of "title" has been changed.
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
| Labels |
Added:
Language Change
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35960.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35960.
| Labels |
Added:
?
Information Required
|
||
In case that a component which uses the workflow
has no method getItem() or
if it does not give back an item
or if the item has not title attribute,
the title cannot be displayed in a message.
A translatable text "unknon title" has been added.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35960.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35960.
| Labels |
Removed:
?
Information Required
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35960.
@brianteeman, could you please check and test PR again in your free time. Thanks.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35960.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35960.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-28 17:27:45 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 10ddab8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35960.