[#35958] - [4.0] [Workflow] Item type is not localized in the subject of the state change notification
- Closed
- 2 Nov 2021
- Medium
- Build: 4.0-dev
- # 35958
Steps to reproduce the issue
-
Use the latest stable version of Joomla.
-
Create a new user, add it to the administrators group (for example).
-
Enable workflows in the content settings.
-
Enable all plugins in the workflow group.
-
Go to the process transitions and, for example, for the "Publish" item in the notification settings, enable the "administrator" user group or a specific user created earlier.
-
Install any other language that is clearly different from en-GB.
-
Create an article, define it in the "Publish" transition.
-
The second created user will receive a private message informing that the state has changed. However, in the subject of the message - the type (in this case Article) will be in English, since these elements are not localized.
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
Everything is in order in the message. Issue only deals with the topic of the notification.
I just wanted to double check
By the way, another Russian-speaking user received a notification with "Form" in the subject.
same bug. I just don't know the fix
It is the model name. Can we translate the model name?
This is the relevant line
We translate the transitionName here
joomla-cms/plugins/workflow/notification/notification.php
Lines 213 to 217 in ebd801a
I tried the same $lang-> but no luck
A simple solution would be:
Changeing the message and insert the title instead of the model name (is this a b/c break?).
"The status of "halloween 2021" has been changed" instead of "The status of an article has been changed"
Also possible but not my favourite:
mapping all modelnames to Language strings
case $modelName == "article"
lang_key = "PLG_WORKFLOW_NOTIFICATION_ARTICLE"
I would go with option 1. Its not breaking anything (afaict) its just fixing a bug and improving the message
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-02 21:34:38 |
| Closed_By | ⇒ | chmst |
I can confirm the Subject is not correct. Can you also confirm please that the message is correct