? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
30 Oct 2021

Pull Request for Issue #35927.

Summary of Changes

This PR fixes issue #35927 and also, some invalid mark up on buttons layout of radio form field.

  1. Move $attribs back to fieldset. It was moved from fieldset to dev by mistake in the PR #19946
  2. Remove required attribute from fieldset because required is invalid attribute for fieldset. I think autofocus should be removed, too, because it is also invalid. But then how should we handle autofocus for radio options? For now, I leave it there
  3. Fix invalid markup for label of disabled option. style="pointer-events: none"' should not be used inside class (you can see this by reviewing code)

Testing Instructions

  1. Open administrator/components/com_banners/config.xml, change https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_banners/config.xml#L24-L33 to the below code to make that field disabled and use buttons layout:
<field
	name="track_impressions"
	type="radio"	
	label="COM_BANNERS_FIELD_TRACKIMPRESSION_LABEL"
	default="0"
	disabled="true"
	>
	<option value="0">JNO</option>
	<option value="1">JYES</option>
</field>
  1. Login to administrator area of your site, access to Banners component, click on Options button in the toolbar to change setting of the component
  2. Press Save button to save the change

Actual result BEFORE applying this Pull Request

You got fatal error because the value of that disabled field still being submitted to server (causes by invalid mark up for the field)

Expected result AFTER applying this Pull Request

Change can be saved properly. Also, please make to the appearance of the field is not changed after PR.

Documentation Changes Required

None.

avatar joomdonation joomdonation - open - 30 Oct 2021
avatar joomdonation joomdonation - change - 30 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2021
Category Layout
3a04edb 30 Oct 2021 avatar joomdonation Typo
avatar joomdonation joomdonation - change - 30 Oct 2021
Labels Added: ?
avatar compojoom
compojoom - comment - 30 Oct 2021

I tested this with my own component Hotspots Core and now it works properly.

Thank you!

avatar joomdonation
joomdonation - comment - 30 Oct 2021

@compojoom Could you please go to https://issues.joomla.org/tracker/joomla-cms/35947 and mark your test result in the issue tracker so that it will be counted? Thanks !

avatar compojoom compojoom - test_item - 30 Oct 2021 - Tested successfully
avatar compojoom
compojoom - comment - 30 Oct 2021

I have tested this item successfully on 3a04edb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35947.

avatar compojoom
compojoom - comment - 30 Oct 2021

done


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35947.

avatar joomdonation
joomdonation - comment - 30 Oct 2021

Thanks !

avatar ChristineWk ChristineWk - test_item - 30 Oct 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 30 Oct 2021

I have tested this item successfully on 3a04edb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35947.

avatar Fedik Fedik - change - 30 Oct 2021
Status Pending Ready to Commit
avatar Fedik
Fedik - comment - 30 Oct 2021

r
t
c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35947.

avatar bembelimen bembelimen - close - 2 Nov 2021
avatar bembelimen bembelimen - merge - 2 Nov 2021
avatar bembelimen bembelimen - change - 2 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-02 15:45:36
Closed_By bembelimen
Labels Added: ?
avatar bembelimen
bembelimen - comment - 2 Nov 2021

Thx

Add a Comment

Login with GitHub to post a comment