User tests: Successful: Unsuccessful:
Pull Request for Issue #35927.
This PR fixes issue #35927 and also, some invalid mark up on buttons layout of radio form field.
fieldset
. It was moved from fieldset to dev by mistake in the PR #19946style="pointer-events: none"'
should not be used inside class (you can see this by reviewing code)<field
name="track_impressions"
type="radio"
label="COM_BANNERS_FIELD_TRACKIMPRESSION_LABEL"
default="0"
disabled="true"
>
<option value="0">JNO</option>
<option value="1">JYES</option>
</field>
You got fatal error because the value of that disabled field still being submitted to server (causes by invalid mark up for the field)
Change can be saved properly. Also, please make to the appearance of the field is not changed after PR.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Layout |
Labels |
Added:
?
|
@compojoom Could you please go to https://issues.joomla.org/tracker/joomla-cms/35947 and mark your test result in the issue tracker so that it will be counted? Thanks !
I have tested this item
done
Thanks !
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
r
t
c
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-02 15:45:36 |
Closed_By | ⇒ | bembelimen | |
Labels |
Added:
?
|
Thx
I tested this with my own component Hotspots Core and now it works properly.
Thank you!