Feeling Lucky
?
?
[#35935] - [4.0] [webservices] wrong parameter for setting Access-Control-Allow-Headers
- Fixed in Code Base
- 7 Nov 2021
- Medium
- Build: 4.0-dev
- # 35935
- Diff
- rjharishabh:cors-allow-headers
User tests: Successful: Unsuccessful:
Summary of Changes
This PR updates the get parameter for setting Access-Control-Allow-Headers
Similar to PR #35893
Testing Instructions
Code review
name cors_allow_headers in XML
<field
name="cors_allow_headers"
type="text"
label="Access-Control-Allow-Headers"
description="COM_CONFIG_FIELD_WEBSERVICES_CORS_ALLOW_HEADERS_DESC"
translate_label="false"
default="Content-Type,X-Joomla-Token"
showon="cors:1"
/>Get parameter is cors_allowed_headers
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
alikon
- comment
- 2 Nov 2021
good catch
has not been discovered yet cause of default Content-Type,X-Joomla-Token
alikon
- comment
- 2 Nov 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35935.
Quy
- comment
- 4 Nov 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35935.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Quy
- comment
- 4 Nov 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35935.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-07 02:36:20 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
bembelimen
- comment
- 7 Nov 2021
Thx
rjharishabh
- comment
- 7 Nov 2021
Thanks
This needs more than a simple
code reviewcomment.I'm not saying the change is right or wrong but as the code was tested and working when it was first submitted and merged...