[#35924] - [4.0] Update FieldsModel.php: Fix missing filter in store id.
- Fixed in Code Base
- 28 Nov 2021
- Medium
- Build: 4.0-dev
- # 35924
- Diff
- janschoenherr:patch-1
User tests: Successful: Unsuccessful:
Fix missing filter in store id.
Pull Request fixes issue introduces here: ff213f6
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Without the filter in the store id, calling
FieldsHelper::getFields('', null, false, null, true)
FieldsHelper::getFields('', null, false, null, false)
in succession, will render the same result.
Expected result AFTER applying this Pull Request
Calling the method twice in the same request:
FieldsHelper::getFields('', null, false, null, true)
Result includes subfields.
FieldsHelper::getFields('', null, false, null, false)
Result does not include subfields.
Documentation Changes Required
no
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Title |
|
||||||
@janschoenherr Please write clear testing instructions for a PR. I know it's not the most fun to do, but keep in mind that technically a layman must (in most cases) be able to test a PR. If testing is not possible leave a comment that a code review is needed. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35924.
I have tested this item
on review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35924.
| Status | Pending | ⇒ | Ready to Commit |
r
t
c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35924.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-28 17:21:14 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
I have tested this item✅ successfully on afd17cb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35924.