[#35922] - [5.2] Add missing id to SubformField hidden input field
- Pending
- Medium
- Build: 4.0-dev
- # 35922
- Diff
- HLeithner:j4/subform/missingid
User tests: Successful: Unsuccessful:
The hidden input of the SubformField has no id attribute.
Summary of Changes
Add the id attribute to the SubformField
Testing Instructions
Code review and check if subforms still work
Actual result BEFORE applying this Pull Request
No id attribute on the input field of the subform
Expected result AFTER applying this Pull Request
An id attribute on the input field of the subform
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
2 fields of type "Subform" in article edit view.
Without PR:
<input name="jform[com_fields][test-subform-field-1]" type="hidden" value="">
...
<input name="jform[com_fields][test-subform-field-2]" type="hidden" value="">
With PR:
<input name="jform[com_fields][test-subform-field-1]" id="jform_com_fields_test_subform_field_1" type="hidden" value="">
...
<input name="jform[com_fields][test-subform-field-2]" id="jform_com_fields_test_subform_field_2" type="hidden" value="">
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35922.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35922.
Switch to draft because I have to validate the some javascript magic
| Status | Ready to Commit | ⇒ | Needs Review |
Swapped from RTC to needs review as it needs more work.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35922.
any reason why it need id?
Only purpose of this field is to force Browser to send empty value (we can do the same trick for checkboxes if someone interesting).
It not used by subform.js or anywhere else.
If I right remember the ID is no required for inputs.
You can just close it, or merge as it is.
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
?
Removed: ? |
||
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
Thank you @HLeithner for your proposal.
The maintenance team thinks, that the ID of a field should cover the whole field, not the hidden input only. Could you open a new PR with the changes? Thank you in advance.
Closing this one.
It's a real pain for consistent, I use javascript to address the value of the subform used in one of my component and that subform is the only field that needs this exception....
| Labels |
Removed:
?
|
||
| Status | Needs Review | ⇒ | Pending |
This pull request has been automatically rebased to 4.3-dev.
This pull request has been automatically rebased to 4.4-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
@HLeithner Are you still working on this? It is still marked as draft.
I only want to have it, don't need to work on it, if other maintainer see the need to have consistency what should I do?
I have tested this item✅ successfully on c6c5711
Patch works! Also tried to add multiple subform fields to see if the ID gets an extra suffix for the second field.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35922.