? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Oct 2021

Summary of Changes

Cassiopeia ships with two color themes, - standard and alternate. And of course if you edit those you will lose the edits on upgrade. This pull request adds the ability to add as many additional color themes as you wish.

Testing Instructions

create a least one additional color theme in the folder media\site\templates\cassiopeia\css\global with a name of custom.....css eg custom_colors_orange.css

Actual result BEFORE applying this Pull Request

In the template style options for cassiopeia only two color themes are available

image

Expected result AFTER applying this Pull Request

Original options are available plus any themes you have created.

image

Documentation Changes Required

yes

avatar brianteeman brianteeman - open - 28 Oct 2021
avatar brianteeman brianteeman - change - 28 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Oct 2021
Category Front End Templates (site)
avatar brianteeman brianteeman - change - 28 Oct 2021
Labels Added: ?
avatar Abernyte-Git
Abernyte-Git - comment - 28 Oct 2021

I have not tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35917.

avatar Abernyte-Git Abernyte-Git - test_item - 28 Oct 2021 - Not tested
avatar Abernyte-Git Abernyte-Git - test_item - 28 Oct 2021 - Tested successfully
avatar Abernyte-Git
Abernyte-Git - comment - 28 Oct 2021

I have tested this item successfully on cadf389


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35917.

avatar ghazal ghazal - test_item - 28 Oct 2021 - Tested successfully
avatar ghazal
ghazal - comment - 28 Oct 2021

I have tested this item successfully on cadf389

Tried this solution on 4.0.4 and 4.1.X, it works perfectly on both versions. Tks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35917.

avatar richard67 richard67 - change - 28 Oct 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 28 Oct 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35917.

avatar dgrammatiko
dgrammatiko - comment - 28 Oct 2021

@brianteeman if child templates are finally part of 4.1 users don't need to create new files, they can create a child and override the existing 2 files.

Also a more generic comment, the approach of customising the template through a SCSS file with contents only the CSS Vars is completely wrong. Why (you might ask)? Well, the process is way more involved than it should be (a form with some colour pickers) but my problem is that it was the wrong call. Bootstrap steadily is converting everything to use CSS Vars and guess what? Once that process is complete you don't need anything more than a form to specify any variable and thus achieve truly customization that anyone can do (no HTML/CSS/SCSS or whatever, pick colours/etc VISUALLY)

avatar brianteeman
brianteeman - comment - 28 Oct 2021

Do I like the contents of this file and the methodology- absolutely not - but thats my personal opinion and I am not a designer.

Creating a child template just so you can change these colours is massive overkill. This is a super simple, fully backwards compatible, no effort means to do it. (It has to be or I wouldnt have been able to create it)

avatar bembelimen
bembelimen - comment - 2 Nov 2021

I'm in favour of having this addition (beside child templates), but (sorry Brian it's then on your shoulders) I would like to merge the child template PR first when they're done and then update the paths in this PR.

avatar brianteeman brianteeman - change - 22 Nov 2021
Labels Added: ?
avatar brianteeman
brianteeman - comment - 22 Nov 2021

ok @bembelimen ping me when the child templates are merged and I will see

avatar Krshivam25 Krshivam25 - test_item - 25 Nov 2021 - Tested successfully
avatar Krshivam25
Krshivam25 - comment - 25 Nov 2021

I have tested this item successfully on cadf389


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35917.

avatar bembelimen
bembelimen - comment - 30 Nov 2021

@brianteeman now you can adjust the path here to target the media folder(s)

avatar brianteeman
brianteeman - comment - 30 Nov 2021

path changed as requested

avatar brianteeman brianteeman - change - 30 Nov 2021
The description was changed
avatar brianteeman brianteeman - edited - 30 Nov 2021
avatar coolcat-creations
coolcat-creations - comment - 30 Nov 2021

@brianteeman I know its not so much related to your PR, but can you remove, that "Standard" loads a sepearate file? I think standard is the default and loading a separate file when nothing changed is quite useless.

avatar brianteeman
brianteeman - comment - 30 Nov 2021

obviously the answer is no.

  1. it is a separate file
  2. how else would you switch to standard from any other color
avatar coolcat-creations
coolcat-creations - comment - 30 Nov 2021

Then we need an option "none" - the standard is the default colour and why would I load a seperate file if the seperate file does not introduce anything new?

avatar brianteeman
brianteeman - comment - 30 Nov 2021

@coolcat-creations so if you don't load colors_standard where does the template get the values from as that is the only place I can find where they are defined.

Anyway it is completely unrelated to this PR

avatar coolcat-creations
coolcat-creations - comment - 30 Nov 2021

Ok,... then hopefully a PR got accepted where the default colours go into the default file, I do not see any sense in loading a separate file with only 3 definitions when it could be in the main file, thats a waste of performance IMHO - the seperate themes can override the default easily

avatar bembelimen bembelimen - change - 30 Nov 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-11-30 09:50:53
Closed_By bembelimen
avatar bembelimen bembelimen - close - 30 Nov 2021
avatar bembelimen bembelimen - merge - 30 Nov 2021
avatar bembelimen
bembelimen - comment - 30 Nov 2021

Thx

avatar brianteeman
brianteeman - comment - 30 Nov 2021

thx

Add a Comment

Login with GitHub to post a comment