[#3591] - [#29831] Cache hit fix
- Closed
- 1 Jan 2015
- Medium
- Build: 2.5.x
- # 3591
- Diff
- dfritsch:cache-hit-fix
- Foreign ID 29831
User tests: Successful: Unsuccessful:
I was facing the same issue as this tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=11410&tracker_item_id=29831 which was closed as expected behavior.
This is a simple shift of the hit trigger from the view to the controller, which is run even when the basic cache is enabled.
If this is an acceptable improvement, I can add a similar change to the appropriate 3.x branch.
Are we sure the controller is being executed when we're doing page caching?
In Joomla 3.3, I threw in a die() statement and an echo in the components/com_content/controller.php, and when I have caching enabled, these lines of code are not executed.
| Labels |
Added:
?
Removed: ? |
||
Yes, when page caching is enabled (system cache plugin), this fix does not work.
I've tried.
But;
at the following address solution really works.
http://www.inmotionhosting.com/support/edu/joomla-3/increase-hits-cache
Can we convert it to fix the core?
| Status | New | ⇒ | Pending |
nicksavov
- | Labels |
Removed:
?
|
||
| Category | ⇒ | Cache |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-01 13:02:36 |
| Closed_By | ⇒ | brianteeman |
Thanks for working on this. Unfortunately this did not make it into the final release of Joomla 2.5, or it was handled elsewhere, so this is being closed. If you feel this is still a valid issue in Joomla 3 please create a new issue.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3591.
I like the change - especially because now you have hits triggered on more than just a html view (e.g. a feed view of your page). However can this not go into the article controller rather than the main parent controller?
Also massive ++ to removing this from the view - it's clearly controller logic