[#35883] - [4.0] TinyMCE languages fix
- Fixed in Code Base
- 21 Jan 2022
- Medium
- Build: 4.0-dev
- # 35883
- Diff
- dgrammatiko:4.0-dev-tiny_langs
User tests: Successful: Unsuccessful:
Pull Request alternative to #35878
Summary of Changes
Load either minified or non minified language files depending on the JDEBUG constant (same as the rest scripts/styles in the core)
Testing Instructions
Same as #35878
Actual result BEFORE applying this Pull Request
Broken
Expected result AFTER applying this Pull Request
Fixed
Documentation Changes Required
No bug fix
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-10-24 10:25:15 |
| Closed_By | ⇒ | dgrammatiko | |
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2021-10-24 10:25:15 | ⇒ | |
| Closed_By | dgrammatiko | ⇒ |
| Status | New | ⇒ | Pending |
yes but this pr is for 4.0 and that pr is for 4.whenever
@chmst the 3rd option from #35878 is not valid with this pr, we do have both min and unminified files. I think you have to check if the list of languages doesn’t have any files with extension and if you peek one then check that is correctly loaded. The images I shared in the description should help. Oh and enabling debug should load the non mini field language script
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35883.
I am getting the following when in edit mode of an article. Please update your branch to rebuilt the package that I can test instead with patch tester. Thanks.
Notice: Trying to get property '0' of non-object in \plugins\editors\tinymce\tinymce.php on line 200
Notice: Trying to get property '2' of non-object in \plugins\editors\tinymce\tinymce.php on line 200
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35883.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35883.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-21 13:16:29 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
Thank you, Ben, just be careful with this one when you push it to 4.1 (in 4.1 the tinyMCE is refactored so you might have to do a bit of copy pasting)
similar problem with the editor.min.css